MeasurementValue raises an error when used as boolean #6386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albi3ro
commented
Oct 11, 2024
mudit2812
approved these changes
Oct 11, 2024
…/PennyLaneAI/pennylane into fix-measurement-value-truthiness
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6386 +/- ##
==========================================
- Coverage 99.71% 99.39% -0.32%
==========================================
Files 448 448
Lines 42466 42472 +6
==========================================
- Hits 42346 42217 -129
- Misses 120 255 +135 ☔ View full report in Codecov by Sentry. |
|
[sc-76023] |
austingmhuang
pushed a commit
that referenced
this pull request
Oct 23, 2024
**Context:**
Users might be able to do:
```
@qml.qnode
def f():
...
m = qml.measure()
if m == 1:
# do something
...
```
without an error, since a measurement value is always treated as truthy,
even if that is not what the user was meaning to do.
**Description of the Change:**
Raises a `ValueError` if someone tries to treat a `MeasurementValue` as
a boolean.
**Benefits:**
Reduces confusion and mistakes when trying to condition on a mid circuit
measurement.
**Possible Drawbacks:**
**Related GitHub Issues:**
mudit2812
pushed a commit
that referenced
this pull request
Nov 11, 2024
**Context:**
Users might be able to do:
```
@qml.qnode
def f():
...
m = qml.measure()
if m == 1:
# do something
...
```
without an error, since a measurement value is always treated as truthy,
even if that is not what the user was meaning to do.
**Description of the Change:**
Raises a `ValueError` if someone tries to treat a `MeasurementValue` as
a boolean.
**Benefits:**
Reduces confusion and mistakes when trying to condition on a mid circuit
measurement.
**Possible Drawbacks:**
**Related GitHub Issues:**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Users might be able to do:
without an error, since a measurement value is always treated as truthy, even if that is not what the user was meaning to do.
Description of the Change:
Raises a
ValueErrorif someone tries to treat aMeasurementValueas a boolean.Benefits:
Reduces confusion and mistakes when trying to condition on a mid circuit measurement.
Possible Drawbacks:
Related GitHub Issues: