Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove expand_depth in compile transform and max_expansion in clifford_t_decomposition transform #6531

Merged
merged 9 commits into from
Nov 11, 2024

Conversation

andrijapau
Copy link
Contributor

@andrijapau andrijapau commented Nov 6, 2024

Context:

Completing the deprecation cycle of expand_depth in compile transform and max_expansion in clifford_t_decomposition transform.

Description of the Change:

  1. Update deprecations.rst
  2. Update changelog-dev.md
  3. Remove all deprecated source code

No references found in Catalyst, Lightning, or QML.

[sc-77499]

Copy link
Contributor

@lillian542 lillian542 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 🚀

@andrijapau andrijapau marked this pull request as ready for review November 7, 2024 15:43
Copy link
Contributor

@mudit2812 mudit2812 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor comment, otherwise LGTM

doc/releases/changelog-dev.md Outdated Show resolved Hide resolved
Co-authored-by: Mudit Pandey <mudit.pandey@xanadu.ai>
@andrijapau andrijapau added the merge-ready ✔️ All tests pass and the PR is ready to be merged. label Nov 8, 2024
@albi3ro albi3ro added the urgent Mark a pull request as high priority label Nov 8, 2024
@albi3ro albi3ro enabled auto-merge (squash) November 8, 2024 21:17
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.29%. Comparing base (e710ca6) to head (8decad4).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6531      +/-   ##
==========================================
+ Coverage   99.17%   99.29%   +0.12%     
==========================================
  Files         456      457       +1     
  Lines       43254    43413     +159     
==========================================
+ Hits        42899    43109     +210     
+ Misses        355      304      -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@albi3ro albi3ro removed the urgent Mark a pull request as high priority label Nov 8, 2024
@andrijapau andrijapau added do not merge ⚠️ Do not merge the pull request until this label is removed and removed merge-ready ✔️ All tests pass and the PR is ready to be merged. labels Nov 8, 2024
@albi3ro albi3ro merged commit a6dabca into master Nov 11, 2024
45 checks passed
@albi3ro albi3ro deleted the remove-decompose-args branch November 11, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge ⚠️ Do not merge the pull request until this label is removed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants