Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't check for warning on PL stable #58

Merged
merged 1 commit into from
Nov 13, 2023
Merged

don't check for warning on PL stable #58

merged 1 commit into from
Nov 13, 2023

Conversation

timmysilv
Copy link
Contributor

turns out the warnings being filtered must exist. this should fix the matrix

@timmysilv timmysilv requested a review from a team November 13, 2023 15:13
@timmysilv timmysilv mentioned this pull request Nov 13, 2023
Merged
@albi3ro
Copy link
Contributor

albi3ro commented Nov 13, 2023

was just about to suggest this 😆

albi3ro
albi3ro approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@albi3ro albi3ro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So it look s like qiskit and project q are still failing on stable-stable, but at least the error messages look unrelated to the deprecation warnings.

@timmysilv timmysilv merged commit 0055eb3 into master Nov 13, 2023
28 of 53 checks passed
@trbromley trbromley deleted the fix-non-latest branch November 13, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albi3ro albi3ro albi3ro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timmysilv @albi3ro