Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update test matrix according to changes to PL-Qiskit plugin #83

Merged
merged 6 commits into from
Aug 8, 2024

Conversation

austingmhuang
Copy link
Contributor

The PL-Qiskit plugin no longer has tests that require an ibmq account. Namely test_ibmq.py and test_runtime.py have been deleted from the plugin CI tests and so are not relevant for the test matrix. This update accounts for the deletion of these tests and makes changes accordingly.

Related Issue:
[sc-69774]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these 5 .github files are changed when compile.py is changed and ran with python3 compile.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand this comment. I thought the yml files are updated because test_ibmq.py and test_runtime.py do not exist anymore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These 5 workflow files are automatically generated by running python3 compile as indicated in the readme. We manually change compile.py, which when executed, changes those 5 workflow files.

README.md Outdated Show resolved Hide resolved
Copy link

@soranjh soranjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that all the tests are failing.

@austingmhuang
Copy link
Contributor Author

Seems that all the tests are failing.

The tests failing for braket are not related to this PR. The qiskit tests seem to be failing due to some test regarding the noise models:

FAILED plugin_repo/tests/test_converter.py::TestLoadNoiseModel::test_build_noise_model - TypeError: ThermalRelaxationError.__init__() got an unexpected keyword argument 'tg'

Maybe @obliviateandsurrender has some insight as to what's happening?

@obliviateandsurrender
Copy link

obliviateandsurrender commented Jul 29, 2024

Please check the pennylane version for which the test matrix is being tested. The thermal relaxation default argument was corrected to tg from tq in the master.

@austingmhuang
Copy link
Contributor Author

Please check the pennylane version for which the test matrix is being tested. The thermal relaxation default argument was corrected to tg from tq in the master.

For the two version that are failing:
1 is using PennyLane-0.38.0.dev0
And the other is using PennyLane-0.37.0

@astralcai astralcai merged commit 6585ba5 into master Aug 8, 2024
38 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants