-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update test matrix according to changes to PL-Qiskit plugin #83
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these 5 .github files are changed when compile.py
is changed and ran with python3 compile
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I understand this comment. I thought the yml files are updated because test_ibmq.py and test_runtime.py do not exist anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These 5 workflow files are automatically generated by running python3 compile
as indicated in the readme. We manually change compile.py
, which when executed, changes those 5 workflow files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that all the tests are failing.
The tests failing for braket are not related to this PR. The qiskit tests seem to be failing due to some test regarding the noise models:
Maybe @obliviateandsurrender has some insight as to what's happening? |
Please check the pennylane version for which the test matrix is being tested. The thermal relaxation default argument was corrected to |
For the two version that are failing: |
The PL-Qiskit plugin no longer has tests that require an ibmq account. Namely
test_ibmq.py
andtest_runtime.py
have been deleted from the plugin CI tests and so are not relevant for the test matrix. This update accounts for the deletion of these tests and makes changes accordingly.Related Issue:
[sc-69774]