Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging updates #174

Merged
merged 10 commits into from
May 16, 2024
Merged

Logging updates #174

merged 10 commits into from
May 16, 2024

Conversation

andrew-welker
Copy link
Contributor

  • Improve formatting: Previous iterations were not including the automatically-generated Exception property that was added by Serilog by using the methods that take an Exception as a parameter. PD Core is now using a Serilog package to handle formatting.
  • Using the Serilog package allowed the removal of empty [] if the message is logged by a class that does NOT implement IKeyed
  • Updated the format of the error log sink to match the console sink if running on VC-4. Otherwise, the format will NOT contain the app, or full time stamp. It will include the Key, if present, and the milliseconds of the timestamp. The rest of the data is already in the text included by the Error log.
  • Added extension methods. These methods allow a class that implements IKeyed to log data by something like this.LogDebug("message template here", other, stuff, here).
  • Added a Serilog enricher to automatically add the App Number/Room Name to every log event

@jgutenplan jgutenplan merged commit d403c29 into development-2 May 16, 2024
1 check passed
@andrew-welker andrew-welker deleted the feature-2/fix-logError-message branch May 16, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants