Added reader_context class #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced "prorocol_traits_fwd.hpp" / "prorocol_traits.hpp" headers with some expected values for Binary Log Protocol V4 constants. Introduced 'binsrv::event::reader_context' class that is expected to be used for storing information about the sequence of encountered events as well as data that may affect parsing / analyzing subsequent events in the stream. 'binsrv::event::event' constructor now accepts an reference to an instance of the 'reader_context' class where the information about the most recently encountered format description event is kept. After some bugs were fixed in 'clang-tidy-17', 'bugprone-exception-escape' NOLINT suppressions are no longer needed and were removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced "prorocol_traits_fwd.hpp" / "prorocol_traits.hpp" headers with some expected values for Binary Log Protocol V4 constants.
Introduced 'binsrv::event::reader_context' class that is expected to be used for storing information about the sequence of encountered events as well as data that may affect parsing / analyzing subsequent events in the stream.
'binsrv::event::event' constructor now accepts an reference to an instance of the 'reader_context' class where the information about the most recently encountered format description event is kept.
After some bugs were fixed in 'clang-tidy-17', 'bugprone-exception-escape' NOLINT suppressions are no longer needed and were removed.