toke.c: remove PERL_CR_FILTER #22787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When enabled (e.g. with `./Configure -A ccflags=-DPERL_CR_FILTER`), this would define an implicit source filter that turns \r\n pairs into \n whenever the parser reads a line of Perl source code. As far as I can tell, perl already does the equivalent of this (without a source filter) on all platforms and has done so since 5.005. (Also, the code could read out-of-bounds if the last character of the line read was a \r.)
leonerd
reviewed
Nov 26, 2024
Yeah, that's what I was sort of implying with
:-P |
|
As to perldelta content, I don't think a huge amount needs adding here. This is a little-known, probably entirely forgotten-about feature, that is being removed. Maybe possible to combine it with the text about the removal of |
|
perldelta entry added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabled (e.g. with
./Configure -A ccflags=-DPERL_CR_FILTER), this would define an implicit source filter that turns \r\n pairs into \n whenever the parser reads a line of Perl source code.As far as I can tell, perl already does the equivalent of this (without a source filter) on all platforms and has done so since 5.005.
(Also, the code could read out-of-bounds if the last character of the line read was a \r.)
I need help writing itit is included.