Minor fixes after PHPMD

Phauthentic · Mar 16, 2024 · ca28e5c · ca28e5c
1 parent 68c5a7f
commit ca28e5c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/src/Authenticator/HttpDigestAuthenticator.php b/src/Authenticator/HttpDigestAuthenticator.php
@@ -305,8 +305,6 @@ protected function loginHeaders(ServerRequestInterface $request): array
             if (is_bool($v)) {
                 $v = $v ? 'true' : 'false';
                 $opts[] = sprintf('%s=%s', $k, $v);
-            } else {
-                $opts[] = sprintf('%s="%s"', $k, $v);
             }
         }
 

diff --git a/src/Identifier/Ldap/ExtensionAdapter.php b/src/Identifier/Ldap/ExtensionAdapter.php
@@ -130,6 +130,7 @@ public function setOption(int $option, $value)
      */
     public function getOption($option)
     {
+        $returnValue = null;
         $this->setErrorHandler();
         ldap_get_option($this->getConnection(), $option, $returnValue);
         $this->unsetErrorHandler();

diff --git a/src/Middleware/AuthenticationErrorHandlerMiddleware.php b/src/Middleware/AuthenticationErrorHandlerMiddleware.php
@@ -75,17 +75,17 @@ public function process(ServerRequestInterface $request, RequestHandlerInterface
      * @param \Phauthentic\Authentication\Authenticator\Exception\UnauthorizedException $e Exception.
      * @return \Psr\Http\Message\ResponseInterface
      */
-    protected function createUnauthorizedResponse(UnauthorizedException $e): ResponseInterface
+    protected function createUnauthorizedResponse(UnauthorizedException $exception): ResponseInterface
     {
         $body = $this->streamFactory->createStream();
-        $body->write($e->getBody());
+        $body->write($exception->getBody());
 
         $response = $this
             ->responseFactory
-            ->createResponse($e->getCode())
+            ->createResponse($exception->getCode())
             ->withBody($body);
 
-        foreach ($e->getHeaders() as $header => $value) {
+        foreach ($exception->getHeaders() as $header => $value) {
             $response = $response->withHeader($header, $value);
         }