-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print trait improvements #718
Conversation
Still needs to address long column names |
@trife, yep still working on that and a few other refinements. I opened the pr to give Russell access to an apk with the initial fixes, but the build action keeps failing with a git server 502 error when trying to PUT the built apk. Not sure how to best troubleshoot that, but in the meantime I'll set this to draft and share a manually built apk. |
On Pixel 6 API 33 I get this when opening print trait, crashes app:
|
@chaney thanks for the heads up. I pushed a partial change to the trait layout to let a user better manage the printer connection, looks like that's what is causing the error. But after talking to Trevor I'm changing the approach somewhat. I'll leave the PR as a draft until it's ready for more testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The only small thing I noticed was that when "blank" was chosen for the barcode, it still prints a barcode.
Description
Provide a summary of your changes including motivation and context.
If these changes fix a bug or resolves a feature request, be sure to link to that issue.
Fixes problem where printing would require re-selecting the printer with each new entry
Adds connection button to layout to allow changing printers
Fixes handing of long text in label print spinners
Closes #174
Type of change
What type of changes does your code introduce? Put an
x
in boxes that apply.CHANGE
(fix or feature that would cause existing functionality to not work as expected)FEATURE
(non-breaking change which adds functionality)BUGFIX
(non-breaking change which fixes an issue)ENHANCEMENT
(non-breaking change which improves existing functionality)NONE
(if none of the other choices apply. Example, tooling, build system, CI, docs, etc.)Checklist:
Changelog entry
Please add a one-line changelog entry below. This will be copied to the changelog file during the release process.