Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Create data loader for XML (Sourcery refactored) #86

Conversation

sourcery-ai[bot]
Copy link

@sourcery-ai sourcery-ai bot commented Dec 30, 2023

Pull Request #82 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the feature/#72/data-loader-for-xml branch, then run:

git fetch origin sourcery/feature/#72/data-loader-for-xml
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot force-pushed the sourcery/feature/#72/data-loader-for-xml branch from 5a421d0 to eb830b4 Compare December 30, 2023 15:51
@sourcery-ai sourcery-ai bot requested a review from garlontas December 30, 2023 15:51
@sourcery-ai sourcery-ai bot force-pushed the sourcery/feature/#72/data-loader-for-xml branch from eb830b4 to 4f34e79 Compare December 30, 2023 15:54
src = xmlfile.read()
if src:
if src := xmlfile.read():
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function __load_xml_file refactored with the following changes:

@garlontas garlontas closed this Dec 30, 2023
Copy link

sonarcloud bot commented Dec 30, 2023

@garlontas garlontas deleted the sourcery/feature/#72/data-loader-for-xml branch December 30, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant