Python gui demo #31
Merged
Python gui demo #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laves
requested changes
Dec 20, 2024
| from concurrent.futures import ThreadPoolExecutor | ||
| from typing import Optional, Sequence | ||
| from itertools import chain | ||
| import curses |
There was a problem hiding this comment.
OCD, but move this up to the import * block and make everything alphabetical order within its own block
|
|
||
|
|
||
| class Generator: | ||
| def __init__(self, queue: Queue, synthesizer: Synthesizer, pllm_connection: Connection, pllm_process: Process): |
There was a problem hiding this comment.
let's break up these longer argument blocks into multiline for better diffs
laves
approved these changes
Dec 20, 2024
matt200-ok
force-pushed
the
python-gui-demo
branch
from
f5dc69e to
319c860
Compare
laves
approved these changes
Dec 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.