Updates example section in the Readme #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…e package and is only used for the repo
for more information, see https://pre-commit.ci
|
Hey @Trybnetic, is this still a work in progress ? |
|
I actually struggled with explaining on the use of |
…found in the .github/ folder
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
for more information, see https://pre-commit.ci
|
Both suggestions look very good to me! Thanks for the proof-read! |
Pierre-Sassoulas
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in #47, this PR updates the documentation in the readme. Specifically, I made the examples consistent in the sense that they are both using the
fruits.txtdataset now and extended the descriptions of the examples a bit.Changes introduced in this PR:
fruits.txtin the examplesI see some further changes that could be included in this PR:
leftWeightandrightWeight