Skip to content

Commit

Permalink
^ Update ruby versions in CI, remove support for rspec version requir…
Browse files Browse the repository at this point in the history
…ing rake 11

Could not test those versions with Ruby 3.2
  • Loading branch information
PikachuEXE committed Jul 17, 2023
1 parent 573ef0d commit c1ec551
Show file tree
Hide file tree
Showing 9 changed files with 14 additions and 58 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/coverage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ jobs:
os:
- ubuntu
ruby:
- 2.7
- "3.2"
gemfile:
- gemfiles/rspec_3_11.gemfile
- gemfiles/rspec_3_12.gemfile
env:
BUNDLE_GEMFILE: ${{ matrix.gemfile }}
COVERALLS: true
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,9 @@ jobs:
os:
- ubuntu
ruby:
- "2.7"
- "3.0"
- "3.1"
- "3.2"
gemfile:
- gemfiles/rspec_3_0.gemfile
- gemfiles/rspec_3_1.gemfile
Expand All @@ -40,12 +40,13 @@ jobs:
- gemfiles/rspec_3_9.gemfile
- gemfiles/rspec_3_10.gemfile
- gemfiles/rspec_3_11.gemfile
- gemfiles/rspec_3_12.gemfile
allow_failures:
- false
include:
- os: ubuntu
ruby: ruby-head
gemfile: gemfiles/rspec_3_11.gemfile
gemfile: gemfiles/rspec_3_12.gemfile
allow_failures: true
env:
BUNDLE_GEMFILE: "${{ matrix.gemfile }}"
Expand Down
30 changes: 5 additions & 25 deletions Appraisals
Original file line number Diff line number Diff line change
@@ -1,28 +1,4 @@

appraise "rspec_3_0" do
gem "rspec", "~> 3.0.0"
# https://github.com/rspec/rspec-core/issues/2205
gem "rake", "< 12"
end

appraise "rspec_3_1" do
gem "rspec", "~> 3.1.0"
# https://github.com/rspec/rspec-core/issues/2205
gem "rake", "< 12"
end

appraise "rspec_3_2" do
gem "rspec", "~> 3.2.0"
# https://github.com/rspec/rspec-core/issues/2205
gem "rake", "< 12"
end

appraise "rspec_3_3" do
gem "rspec", "~> 3.3.0"
# https://github.com/rspec/rspec-core/issues/2205
gem "rake", "< 12"
end

appraise "rspec_3_4" do
gem "rspec", "~> 3.4.0"
end
Expand Down Expand Up @@ -52,5 +28,9 @@ appraise "rspec_3_10" do
end

appraise "rspec_3_11" do
gem "rspec", "~> 3.10.0"
gem "rspec", "~> 3.11.0"
end

appraise "rspec_3_12" do
gem "rspec", "~> 3.12.0"
end
8 changes: 0 additions & 8 deletions gemfiles/rspec_3_1.gemfile

This file was deleted.

2 changes: 1 addition & 1 deletion gemfiles/rspec_3_11.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@

source "https://rubygems.org"

gem "rspec", "~> 3.10.0"
gem "rspec", "~> 3.11.0"

gemspec path: "../"
3 changes: 1 addition & 2 deletions gemfiles/rspec_3_0.gemfile → gemfiles/rspec_3_12.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

source "https://rubygems.org"

gem "rspec", "~> 3.0.0"
gem "rake", "< 12"
gem "rspec", "~> 3.12.0"

gemspec path: "../"
8 changes: 0 additions & 8 deletions gemfiles/rspec_3_2.gemfile

This file was deleted.

8 changes: 0 additions & 8 deletions gemfiles/rspec_3_3.gemfile

This file was deleted.

4 changes: 2 additions & 2 deletions rspec-json_matchers.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@ Gem::Specification.new do |spec|

spec.add_dependency "abstract_class", "~> 1.0", ">= 1.0.1"
spec.add_dependency "awesome_print", "~> 1.6"
spec.add_dependency "rspec", "~> 3.0"
spec.add_dependency "rspec", "~> 3.4"

spec.add_development_dependency "rake", ">= 10.0", "<= 14.0"
spec.add_development_dependency "appraisal", "~> 2.0"
spec.add_development_dependency "appraisal", "~> 2.0", ">= 2.5.0"
spec.add_development_dependency "rspec-its", "~> 1.0"
spec.add_development_dependency "simplecov", ">= 0.21"
spec.add_development_dependency "simplecov-lcov", ">= 0.8"
Expand Down

0 comments on commit c1ec551

Please sign in to comment.