Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(script/flow): add script ga script create_github_release.ts #3095

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Aug 29, 2024

Usage:

dryrun mode:

deno run --allow-all scripts/flow/ga/create_github_release.ts --dryrun --version=v8.1.2 --
token=<github_token>

normal run mode:

deno run --allow-all scripts/flow/ga/create_github_release.ts --version=v8.1.2 --
token=<github_token>

Signed-off-by: wuhuizuo wuhuizuo@126.com

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Copy link

ti-chi-bot bot commented Aug 29, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary:
This pull request adds a new script called create_github_release.ts to the scripts/flow/ga/ directory. This script allows creating GitHub releases for multiple repositories at once. It also renames two existing scripts from the scripts/artifacts directory to the scripts/flow/rc directory.

Potential problems:

  • It's not clear from the description why the two existing scripts were renamed and moved to a new directory. It would be helpful to add more context or explanation in the pull request description.
  • There are no tests for the new script. It would be good to add some tests to ensure it works as expected and doesn't break any existing functionality.

Fixing suggestions:

  • Add more context or explanation in the pull request description about why the two existing scripts were renamed and moved to a new directory.
  • Add tests for the new script to ensure it works as expected and doesn't break any existing functionality.

@ti-chi-bot ti-chi-bot bot requested a review from purelind August 29, 2024 02:00
@ti-chi-bot ti-chi-bot bot added the size/L label Aug 29, 2024
@wuhuizuo
Copy link
Collaborator Author

ref: PingCAP-QE/ee-ops#1240

@wuhuizuo wuhuizuo added the lgtm label Aug 29, 2024
@wuhuizuo
Copy link
Collaborator Author

/approve

Copy link

ti-chi-bot bot commented Aug 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 29, 2024
@ti-chi-bot ti-chi-bot bot merged commit 92fe3bf into main Aug 29, 2024
1 check passed
@ti-chi-bot ti-chi-bot bot deleted the feature/add-create-release-script branch August 29, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant