fix: pass param to jenkins

Signed-off-by: lijie <lijie@pingcap.com>
PingCAP-QE · Dec 13, 2023 · 1fef7da · 1fef7da
1 parent b64879b
commit 1fef7da
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/tibuild/pkg/rest/service/dev_build_service.go b/tibuild/pkg/rest/service/dev_build_service.go
@@ -57,6 +57,7 @@ func (s DevbuildServer) Create(ctx context.Context, req DevBuild, option DevBuil
 		"BuilderImg":        entity.Spec.BuilderImg,
 		"ProductDockerfile": entity.Spec.ProductDockerfile,
 		"ProductBaseImg":    entity.Spec.ProductBaseImg,
+		"TargetImg":         entity.Spec.TargetImg,
 	}
 	qid, err := s.Jenkins.BuildJob(ctx, jobname, params)
 	if err != nil {

diff --git a/tibuild/pkg/rest/service/dev_build_service_test.go b/tibuild/pkg/rest/service/dev_build_service_test.go
@@ -75,7 +75,8 @@ func TestDevBuildCreate(t *testing.T) {
 		require.Equal(t, int64(0), entity.Status.PipelineBuildID)
 		require.Equal(t, map[string]string{"Edition": "enterprise", "GitRef": "pull/23", "Product": "tidb",
 			"Version": "v6.1.2", "PluginGitRef": "master", "IsPushGCR": "false", "IsHotfix": "false", "Features": "",
-			"GithubRepo": "pingcap/tidb", "TiBuildID": "1", "BuildEnv": "", "ProductDockerfile": "", "BuilderImg": "", "ProductBaseImg": ""}, mockedJenkins.params)
+			"GithubRepo": "pingcap/tidb", "TiBuildID": "1", "BuildEnv": "", "ProductDockerfile": "", "BuilderImg": "",
+			"ProductBaseImg": "", "TargetImg": ""}, mockedJenkins.params)
 		mockedJenkins.resume <- struct{}{}
 		time.Sleep(time.Millisecond)
 		require.Equal(t, int64(2), mockedRepo.saved.Status.PipelineBuildID)