-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tibuild): support build with tekton engine for pull requests #138
Conversation
The pull request adds support for building with the Tekton engine for pull requests. It changes the implementation of the The code changes look good and the tests pass. However, there are a few suggestions to improve the code:
Overall, the changes look good, and the code is well-organized and easy to read. |
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
69051c4
to
3481e1c
Compare
The pull request titled "feat(tibuild): support build with tekton engine for pull requests" introduces a feature for supporting the build process with the Tekton engine for pull requests. Here are the key changes:
Potential Problems:
Fixing Suggestions:
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ref: PingCAP-QE/ee-apps#138 Signed-off-by: wuhuizuo <wuhuizuo@126.com>
ref: PingCAP-QE/ee-apps#138 Signed-off-by: wuhuizuo <wuhuizuo@126.com> Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Signed-off-by: wuhuizuo wuhuizuo@126.com