Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tibuild): update user guide link #143

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

wuhuizuo
Copy link
Contributor

@wuhuizuo wuhuizuo commented Jun 6, 2024

Signed-off-by: wuhuizuo wuhuizuo@126.com

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested a review from purelind June 6, 2024 07:01
Copy link

ti-chi-bot bot commented Jun 6, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request, the key change made is updating the user guide link in the README.md file and also in the Header.js file of the tibuild directory. The old user guide link https://pingcap.feishu.cn/wiki/wikcnlRSh8dyOoHGbMQEJN9x77d has been replaced with a new user guide link https://pingcap-cn.feishu.cn/wiki/ST9jwAE5ZiPHJUkFjT4cspRSnAf.

There are no potential problems in this pull request. However, it is important to ensure that the new user guide link is correct and functional.

For fixing suggestions, I would suggest adding a description of the change made in the pull request title and description. This would make it easier for reviewers to understand the purpose of the changes made. Also, it is important to ensure that the new user guide link is properly tested before merging the pull request to avoid any broken links in the future.

@ti-chi-bot ti-chi-bot bot added the size/S label Jun 6, 2024
Copy link

@purelind purelind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 6, 2024
Copy link

ti-chi-bot bot commented Jun 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-06-06 07:03:23.610614876 +0000 UTC m=+16157.663926800: ☑️ agreed by purelind.

@wuhuizuo
Copy link
Contributor Author

wuhuizuo commented Jun 6, 2024

/approve

Copy link

ti-chi-bot bot commented Jun 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: purelind, wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 6, 2024
@ti-chi-bot ti-chi-bot bot merged commit 63d1681 into main Jun 6, 2024
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/tibuild/user-guide branch June 6, 2024 07:53
wuhuizuo added a commit to PingCAP-QE/ee-ops that referenced this pull request Jun 6, 2024
ti-chi-bot bot pushed a commit to PingCAP-QE/ee-ops that referenced this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants