Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cloudevents-server): refactor pkg struct #171

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

wuhuizuo
Copy link
Contributor

No description provided.

Copy link

ti-chi-bot bot commented Sep 26, 2024

I Skip it since the diff size(83154 bytes > 80000 bytes) is too large

Copy link

ti-chi-bot bot commented Sep 26, 2024

I Skip it since the diff size(83461 bytes > 80000 bytes) is too large

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@wuhuizuo wuhuizuo force-pushed the feature/cloudevents-server-publish-tiup branch from 02e7226 to d4b9b67 Compare September 26, 2024 14:14
@ti-chi-bot ti-chi-bot bot added size/L and removed size/XL labels Sep 26, 2024
Copy link

ti-chi-bot bot commented Sep 26, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

The pull request titled "refactor(cloudevents-server): refactor pkg struct" contains several changes.

Key Changes:

  1. Update the Go version from 1.22.4 to 1.23.1 in Dockerfile.
  2. Update the Go version from 1.21 to 1.23 in go.mod and added a toolchain with version go1.23.1.
  3. Addition of new dependency 'github.com/Masterminds/sprig/v3 v3.3.0' and 'github.com/segmentio/kafka-go v0.4.47' in go.mod
  4. Updated multiple dependencies to their newer versions in go.mod.
  5. Removal of indirect dependencies from a separate 'require' block and addition of them into the main 'require' block in go.mod.
  6. Refactoring of the package structure in the handlers.go file, moving from custom to the main directory.
  7. Change in error handling from HTTP-based to a more general approach using cloudevents' NewReceipt in handler files.
  8. Minor changes in strings and error messages.

Potential Problems:

  1. The updated dependencies might cause compatibility issues if not properly tested.
  2. The structural changes in the packages need to be checked for breaking any existing functionality.

Suggestions for Fixes:

  1. Please ensure that the updated dependencies do not break any existing functionality. All the tests should be passed.
  2. The changes in the package structure should be reviewed in detail to ensure it does not break any existing code.
  3. The changes in the error handling approach should be tested thoroughly to ensure the correct functioning of the events.

@wuhuizuo
Copy link
Contributor Author

/approve

Copy link

ti-chi-bot bot commented Sep 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 26, 2024
@ti-chi-bot ti-chi-bot bot merged commit da3f56b into main Sep 26, 2024
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/cloudevents-server-publish-tiup branch September 26, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant