Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jenkins/release/jenkins): delete obc ci-pipeline-cache #1199

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Aug 3, 2024

the previous can not be GC well.

Signed-off-by: wuhuizuo wuhuizuo@126.com

the previous can not be GC well.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested a review from purelind August 3, 2024 06:20
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Aug 3, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it seems like the change being made here is to delete an OBC (ObjectBucketClaim) named ci-pipeline-cache which was previously used for caching Jenkins pipeline artifacts. The reason for the change is that the OBC cannot be garbage collected properly.

Looking at the diff, the only change being made is the deletion of the ci-pipeline-cache OBC definition, and it is being replaced with a new OBC named ci-pipeline-cache2.

There are no obvious problems with this change. However, it would be helpful to have more context around why the OBC cannot be garbage collected properly, and if there are any potential implications for deleting it.

One suggestion for improvement would be to include more detailed commit messages and a link to any relevant Jira tickets or documentation to provide more context for reviewers.

Copy link
Collaborator Author

@wuhuizuo wuhuizuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit e7fe803 into main Aug 3, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/delete-old-pvc branch August 3, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant