Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jenkins/release/jenkins-beta): upgrade jenkins to v2.440.3 #1202

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Aug 3, 2024

Signed-off-by: wuhuizuo wuhuizuo@126.com

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested a review from purelind August 3, 2024 07:17
Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the provided information, the key change in the pull request is an upgrade of Jenkins to version 2.440.3. Specifically, the version field in the chart section of release.yaml is changed from 5.0.13 to 5.1.14, and the tag field in values-controller.yaml is commented out to allow it to use the latest version.

There are no potential problems that can be seen from the provided information.

To improve the pull request, the submitter could provide more context and explanation in the pull request description. It is also recommended to provide more information on the changes made in values-controller-plugins.yaml as this file is also modified in the pull request.

@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster size/XS labels Aug 3, 2024
Copy link
Collaborator Author

@wuhuizuo wuhuizuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 3, 2024
@ti-chi-bot ti-chi-bot bot merged commit ae0210a into main Aug 3, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/bump-beta-jenkins branch August 3, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant