Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jenkins/release/jenkins): overwrite plugins with list in GitOps #1206

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Aug 3, 2024

Signed-off-by: wuhuizuo wuhuizuo@126.com

Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the PR title and description, it seems that the changes made in this PR are related to Jenkins release and plugins installation.

The key changes are:

  • overwritePlugins parameter has been added with a value of true.
  • initializeOnce parameter has been moved under controller and given a value of true.

Regarding potential problems, the changes made in this PR seem straightforward and don't raise any immediate concerns. However, the following suggestions could be made to further improve the code quality and efficiency:

  • Adding a comment explaining the reason for adding overwritePlugins and initializeOnce parameters to the YAML file.
  • Checking if this change could cause any impact on the existing Jenkins pipeline or other dependencies.
  • Running automated tests to ensure that the changes made in this PR are working as expected.

Overall, this PR looks good and can be merged after considering the suggestions mentioned above.

@ti-chi-bot ti-chi-bot bot requested a review from purelind August 3, 2024 09:47
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster size/XS labels Aug 3, 2024
Copy link
Collaborator Author

@wuhuizuo wuhuizuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Copy link
Contributor

ti-chi-bot bot commented Aug 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 3, 2024
@ti-chi-bot ti-chi-bot bot merged commit 8e171fb into main Aug 3, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/overwirtePlugins branch August 3, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant