Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apps/prod/kafka): add cluster and topics #1218

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Aug 6, 2024

Signed-off-by: wuhuizuo wuhuizuo@126.com

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested a review from purelind August 6, 2024 14:21
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Aug 6, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 6, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request, the following changes have been made:

  • Added a new Kafka cluster named cluster-cd in the cd namespace with 3 controller and broker replicas each.
  • Added 4 new Kafka topics in the cluster-cd cluster.

Potential problems that need to be addressed:

  • It is not clear if there are any dependencies on other components or services.
  • No testing details have been provided in the pull request.
  • It is not clear if the new cluster and topics have been properly configured for production use.
  • No information is provided on how the new cluster will be monitored and maintained.

Fixing suggestions:

  • Check if there are any dependencies on other components or services before merging the changes.
  • Request the submitter to provide testing details with the pull request.
  • Ensure that the new cluster and topics have been properly configured and tested before deploying to production.
  • Request the submitter to provide information on how the new cluster will be monitored and maintained.

@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Aug 6, 2024

/approve

@ti-chi-bot ti-chi-bot bot added the size/L label Aug 6, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 6, 2024
@ti-chi-bot ti-chi-bot bot merged commit 43ea6fe into main Aug 6, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/add-kafka-cluster-and-topics branch August 6, 2024 14:23
wuhuizuo added a commit that referenced this pull request Aug 7, 2024
Signed-off-by: wuhuizuo <wuhuizuo@126.com>

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant