Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(apps/prod/tekton/configs/triggers): limit harbor push event resource url #1223

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

wuhuizuo
Copy link
Collaborator

limit it to special server

Signed-off-by: wuhuizuo wuhuizuo@126.com

…ource url

limit it to special server

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested a review from purelind August 15, 2024 03:09
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Aug 15, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 15, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

This pull request limits Harbor push event resource URL to a special server. The change is made in the file event-listener-internal.yaml, artifact-push-on-harbor.yaml, image-push-on-harbor.yaml and harbor/artifact-push-on-harbor.yaml.

There are no potential problems in this pull request. However, it is recommended to add some comments in the code to explain why this limitation is added. It would also be helpful to add some test cases to ensure the functionality is working as expected.

As a code reviewer, some fixing suggestions would be to add comments to the code to explain the changes, add some test cases to ensure proper functionality, and make sure the changes do not affect any other parts of the application.

@ti-chi-bot ti-chi-bot bot added the size/M label Aug 15, 2024
@wuhuizuo
Copy link
Collaborator Author

/approve

Copy link
Contributor

ti-chi-bot bot commented Aug 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 15, 2024
@ti-chi-bot ti-chi-bot bot merged commit 21d830b into main Aug 15, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/limit-harbor-event-source-server branch August 15, 2024 03:11
wuhuizuo added a commit that referenced this pull request Aug 15, 2024
…ent resource url (#1223)

limit it to special new harbor instance.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
ti-chi-bot bot pushed a commit that referenced this pull request Aug 15, 2024
…ent resource url (#1223) (#1226)

limit it to special new harbor instance.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant