Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore(apps/prod/tekton/configs/triggers): limit oci artifacts push event resource url (#1223)" #1228

Conversation

wuhuizuo
Copy link
Collaborator

Reverts #1226

@ti-chi-bot ti-chi-bot bot requested a review from purelind August 19, 2024 02:33
Copy link
Contributor

ti-chi-bot bot commented Aug 19, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from wuhuizuo, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

ti-chi-bot bot commented Aug 19, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it seems that the changes proposed in this pull request are to revert a previous change made in pull request #1226. The diff shows that the change being reverted is related to the URLs used for pushing OCI artifacts to a harbor image repository. Specifically, the URLs have been changed to use 'hub.pingcap.net/' instead of 'hub-mig.pingcap.net/'.

It's difficult to identify any potential problems with this revert without more context about why the previous change was made and why it is being reverted. However, if the previous change was made for a good reason and this revert is not necessary, then it could potentially cause issues with the deployment process.

If the revert is necessary, then it seems that the only change being made is to replace the URLs with the original ones. Therefore, there are no suggestions for further changes.

Overall, it would be helpful to have more context about why this revert is necessary to fully evaluate the pull request.

@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster size/XS labels Aug 19, 2024
@wuhuizuo wuhuizuo closed this Aug 19, 2024
@wuhuizuo wuhuizuo deleted the revert-1226-fix/migrate-tiup-publish-listener-to-another-harbor branch August 19, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/apps env/prod will deploy on the main product cluster size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant