Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/support wide version tag for tidb operator #1234

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

wuhuizuo
Copy link
Collaborator

No description provided.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
…e-version`

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested a review from purelind August 27, 2024 10:53
@ti-chi-bot ti-chi-bot bot added the area/apps label Aug 27, 2024
Copy link
Contributor

ti-chi-bot bot commented Aug 27, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

The pull request is fixing an issue with the tidb operator where it does not support wide version tags. Specifically, the changes include modifying the regular expression to allow for tags with suffixes like "-alpha" or "-beta" and deleting non-standard tags.

One potential problem with this change is that it might accidentally delete tags that are not semver compliant but are still important. The pull request suggests that this change will only delete non-standard tags if the repo has standard semver tags, but this should be verified and tested thoroughly before merging.

Another potential issue is that the regex changes might not be flexible enough to handle all future versions of the tidb operator. The regex should be reviewed to ensure that it is as flexible as possible.

Overall, the changes look good, but it is recommended to test these changes in a staging environment before merging them into the production environment.

@ti-chi-bot ti-chi-bot bot added env/prod will deploy on the main product cluster size/XS labels Aug 27, 2024
@wuhuizuo
Copy link
Collaborator Author

/approve

Copy link
Contributor

ti-chi-bot bot commented Aug 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Aug 27, 2024
@ti-chi-bot ti-chi-bot bot merged commit 596f543 into main Aug 27, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/support-wide-version-tag-for-tidb-operator branch August 27, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant