Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apps/prod/tekton/configs/tasks): add params force-version in task publish-tiup-from-oci-artifact #1243

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Sep 3, 2024

Ref: PingCAP-QE/artifacts#396
Signed-off-by: wuhuizuo wuhuizuo@126.com

…ask `publish-tiup-from-oci-artifact`

Ref: PingCAP-QE/artifacts#396
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested a review from purelind September 3, 2024 08:20
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Sep 3, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 3, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it seems that the changes are adding a new parameter force-version in the task publish-tiup-from-oci-artifact. This parameter is used to forcefully set the version of the artifact, and the default value is an empty string.

Overall, the changes look fine, and there are no obvious problems. However, here are a few suggestions that might be helpful:

  1. It would be good to add some documentation about this new parameter in the task's README file so that users can understand its purpose and usage.

  2. It might be a good idea to add some validation logic for the force-version parameter to ensure that it is a valid version string or empty.

  3. It would be helpful to add some tests to ensure that the force-version parameter is working as expected.

Overall, the changes look good, and I would approve this pull request.

@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Sep 3, 2024

/approve

@ti-chi-bot ti-chi-bot bot added the size/XS label Sep 3, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 3, 2024
@ti-chi-bot ti-chi-bot bot merged commit 75f4c96 into main Sep 3, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/support-publish-tiup-with-force-version branch September 3, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant