Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/prod/tekton/configs/triggers): fix trigger git-push-pingcap-tidb-enterprise-without-plugins #1244

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Sep 3, 2024

Signed-off-by: wuhuizuo wuhuizuo@126.com

…tidb-enterprise-without-plugins

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested a review from purelind September 3, 2024 11:51
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Sep 3, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 3, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, the author has fixed an issue related to the git-push-pingcap-tidb-enterprise-without-plugins trigger in the apps/prod/tekton/configs/triggers folder. The change involves modifying the regular expression in the body.ref.matches condition from '^refs/heads/(feature/release-[0-9]+[.][0-9]+-.*)$' to '^refs/heads/(feature/release-[7-9]+[.][0-9]+-.*)$'.

The potential issue with this change is that it may be too restrictive and prevent certain valid branch names from triggering the pipeline. For example, if a branch is named feature/release-6.0.0-new-feature, it will not trigger the pipeline.

To fix this, the regular expression in the condition can be modified to allow for any minor version number greater than or equal to 7: '^refs/heads/(feature/release-(0|[7-9])\.[0-9]+-.*)$'.

Therefore, the review feedback can be given as follows:

  1. The PR looks good and the change seems valid.
  2. However, the regular expression in the condition may be too restrictive and prevent certain valid branch names from triggering the pipeline.
  3. To fix this, the regular expression can be modified to allow for any minor version number greater than or equal to 7: '^refs/heads/(feature/release-(0|[7-9])\.[0-9]+-.*)$'.
  4. Once the change is made, the code can be further tested to ensure it works as expected.

@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Sep 3, 2024

/approve

@ti-chi-bot ti-chi-bot bot added the size/XS label Sep 3, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 3, 2024
@ti-chi-bot ti-chi-bot bot merged commit 82ecf7a into main Sep 3, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/feature-branch-builds branch September 3, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant