Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore(apps/prod/tekton/configs/triggers): tmp disable sync for lt v8.x images" #1269

Merged

Conversation

wuhuizuo
Copy link
Collaborator

Reverts #1264

@ti-chi-bot ti-chi-bot bot requested a review from purelind September 27, 2024 08:20
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Sep 27, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 27, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it seems that the changes are to revert a previous change made in Pull Request #1264. The actual change in the diff file is to modify a regular expression that matches tags of Docker images pushed to a harbor registry. Specifically, the regular expression now allows tags with versions like "v10.0.1" instead of only allowing tags with versions like "v8.0.1".

Potential problems:

  • It's unclear from the pull request title and description why this change is being reverted. This could be a problem if the original change was made to fix a bug or address a security issue, and reverting it could reintroduce those problems.
  • The regular expression change seems minor and unrelated to the change being reverted. The reason for reverting the previous change should be clarified in the pull request description.

Suggestions for fixing:

  • If the revert was made due to a problem caused by the previous change, the pull request description should explain the problem and why reverting is the correct solution.
  • If the regular expression change is unrelated to the reason for the revert, it should be separated into a separate pull request to avoid confusion and make the changes easier to review.

@wuhuizuo
Copy link
Collaborator Author

/approve

Copy link
Contributor

ti-chi-bot bot commented Sep 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit aecdbd8 into main Sep 27, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the revert-1264-fix/temp-disable-low-version-image-trigger branch September 27, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant