Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/prod/tekton/configs/tasks/release): avoid label be removed by prow plugins #1286

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Oct 15, 2024

This pull request includes a small but important change to the create-pr-to-bump-tikv-version.yaml file in the spec directory. The change addresses an issue where the prow plugin removes the approved label by adding a delay and reapplying the necessary labels.

Signed-off-by: wuhuizuo wuhuizuo@126.com

…y prow plugins

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested a review from purelind October 15, 2024 06:05
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Oct 15, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 15, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, the key change in this pull request is to fix a problem with the prow plugin removing the approved label. This is achieved by adding a sleep and then editing the pull request to add the approved label.

One potential problem with this approach is that the sleep time of 10 seconds is arbitrary and may not be sufficient in all cases. It would be better to find a more reliable way of ensuring that the approved label is not removed by the prow plugin.

A possible fix for this issue could be to modify the prow plugin to not remove the approved label. Alternatively, the pull request could be modified to check if the approved label has been removed and then add it back if necessary. This would eliminate the need for the sleep and make the process more reliable.

Overall, the changes in this pull request seem reasonable, but it would be good to investigate the issue with the prow plugin further and consider alternative solutions.

@ti-chi-bot ti-chi-bot bot added the size/XS label Oct 15, 2024
@wuhuizuo
Copy link
Collaborator Author

/approve

Copy link
Contributor

ti-chi-bot bot commented Oct 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 15, 2024
@ti-chi-bot ti-chi-bot bot merged commit d925881 into main Oct 15, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/tikv-bump-task branch October 15, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant