Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(apps/prod/tekton/configs): use delicated publisher to fast tiup publishing #1298

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

wuhuizuo
Copy link
Collaborator

  • make fast and stable for staging nightly ad RC tiup pkg publishing
  • make fast and stable for GA tiup pkg publishing.
  • rate limit for nightly is not implemented yet, so we still use old way for prod nightly publising.

@ti-chi-bot ti-chi-bot bot requested a review from purelind October 28, 2024 03:21
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster labels Oct 28, 2024
Copy link
Contributor

ti-chi-bot bot commented Oct 28, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it seems like the changes made are related to optimizing the publishing of TIUP packages for different environments. The new implementation uses a dedicated publisher to speed up the publishing process for staging, nightly, and GA packages.

Looking at the diff, the main changes are the addition of a new task publish-tiup-from-oci-artifact-v2.yaml and the modification of the trigger template to use this task instead of the old one publish-tiup-from-oci-artifact.yaml. The new task fetches the manifest config, gets the .tiup file from the config, and loops to publish to the TIUP mirror.

However, there are a few potential issues that need to be addressed:

  • The rate limit for nightly is not implemented yet, so the old way is still being used for prod nightly publishing. This could cause inconsistency in the publishing process and should be resolved before merging this PR.
  • The new task is using a hard-coded URL for the publisher. It would be better to use a variable or configuration file to specify the URL, which would make it easier to switch between different publishers in the future.
  • The new task does not have any error handling or retries in case of failures during publishing. This could cause the publishing process to fail silently, leading to issues down the line.

To address these issues, I suggest the following:

  • Implement rate limiting for nightly publishing to ensure consistency across environments.
  • Use a variable or configuration file to specify the publisher URL, which will make it easier to switch between different publishers in the future.
  • Add error handling and retries to the new task to ensure that publishing failures are handled properly and do not cause issues down the line.

@ti-chi-bot ti-chi-bot bot added the size/L label Oct 28, 2024
@wuhuizuo
Copy link
Collaborator Author

/approve

Copy link
Contributor

ti-chi-bot bot commented Oct 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 28, 2024
…iup publishing

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
Copy link
Contributor

ti-chi-bot bot commented Oct 28, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

This pull request aims to refactor the publish-tiup-from-oci-artifact.yaml task by adding a new task called publish-tiup-from-oci-artifact-v2.yaml to use a dedicated publisher to improve the stability and speed of publishing TIUP packages. The changes also allow for the customization of the publisher URL and force version. However, rate limiting for nightly is not implemented yet, so the old way is still used for prod nightly publishing.

One potential problem is that the rate limiting for nightly publishing is not yet implemented, which could cause issues with the stability and speed of publishing.

To fix this issue, the team could look into implementing rate limiting for nightly publishing to ensure that it is stable and efficient. Additionally, they could consider adding more tests to ensure that the changes made in this pull request do not cause any issues.

Overall, the changes made in this pull request seem to be beneficial for the stability and speed of publishing TIUP packages.

@ti-chi-bot ti-chi-bot bot merged commit a63ae5f into main Oct 28, 2024
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/tiup-publish-event branch October 28, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant