Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/prod/tekton): fix issue of event listener issue #651

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

wuhuizuo
Copy link
Collaborator

Also refactored the ingress to a special dir ingress.
Ref: https://fluxcd.io/flux/components/kustomize/kustomization/#post-build-variable-substitution

Signed-off-by: wuhuizuo wuhuizuo@126.com

@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind July 21, 2023 09:53
@ti-chi-bot ti-chi-bot bot added the size/L label Jul 21, 2023
@wuhuizuo wuhuizuo force-pushed the fix/tekton-event-listener-ingress branch from 9e125ab to 1000407 Compare July 21, 2023 09:55
@ti-chi-bot ti-chi-bot bot added size/M and removed size/L labels Jul 21, 2023
@wuhuizuo wuhuizuo force-pushed the fix/tekton-event-listener-ingress branch from 1000407 to 57bdb3f Compare July 21, 2023 09:57
Also refactored the ingress to a special dir `ingress`.
Ref: https://fluxcd.io/flux/components/kustomize/kustomization/#post-build-variable-substitution

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@wuhuizuo wuhuizuo force-pushed the fix/tekton-event-listener-ingress branch from 57bdb3f to 0962231 Compare July 21, 2023 10:24
@wuhuizuo wuhuizuo added the lgtm label Jul 21, 2023
@wuhuizuo
Copy link
Collaborator Author

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 21, 2023
@ti-chi-bot ti-chi-bot bot merged commit 3927a09 into main Jul 21, 2023
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/tekton-event-listener-ingress branch July 21, 2023 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant