-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ccache pvc #654
feat: add ccache pvc #654
Conversation
Signed-off-by: lijie <lijie@pingcap.com>
Overall, this pull request seems good. However, more information about testing and storage size may be needed. |
Signed-off-by: lijie <lijie@pingcap.com>
Review for PR: feat: add ccache pvcSummaryThis PR is adding a new feature to the project by adding a PVC (Persistent Volume Claim) for CCache. The PR includes the new PVC definition and a Kustomization file to apply the changes. Potential Problems
Fixing Suggestions
Overall ImpressionThe PR is adding a new feature to the project by adding a PVC for CCache. It is well documented and tested. The changes are simple and clear and do not affect the existing code. Therefore, I approve this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wuhuizuo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
Why:
How:
Testing: