Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(apps/prod/tekton/config): rename tekton resources #673

Merged
merged 1 commit into from
Sep 2, 2023

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Sep 2, 2023

Signed-off-by: wuhuizuo wuhuizuo@126.com

@ti-chi-bot ti-chi-bot bot requested a review from jayl1e September 2, 2023 09:11
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 2, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.

Review of GitHub Pull Request

Summary

This pull request renames the Tekton resources. Specifically, it renames demo-pipeline1 to demo and github-pr-public to github-pr-demo.

Potential Problems

There are no potential problems with this pull request.

Fixing Suggestions

No fixing suggestions are needed.

@ti-chi-bot ti-chi-bot bot requested a review from purelind September 2, 2023 09:11
@ti-chi-bot ti-chi-bot bot added the size/M label Sep 2, 2023
Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 2, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
Summary:
The PR renames some Tekton resources, specifically demo-pipeline1 to demo, public.yaml to demo.yaml, and github-pr-public to github-pr-demo. It also removes the set-github-status-start and set-github-status-end tasks and replaces the go-test task with a new hello task.

Potential problems:
It's not clear from the PR description why the resources are being renamed. It also seems that the set-github-status-* tasks are being removed without a clear replacement. Additionally, the new hello task is not very informative and may not be necessary.

Fixing suggestions:
The PR author should provide a clear reason for renaming the resources, and if possible, provide a replacement for the set-github-status-* tasks. The hello task should also be updated to provide more meaningful output or removed altogether if it's not needed.

@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Sep 2, 2023

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 2, 2023
@ti-chi-bot ti-chi-bot bot merged commit 4d03c8f into main Sep 2, 2023
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/tekton-pipeline1 branch September 2, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant