Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/prod/jenkins/pre): fix cronjob with deno image #674

Merged
merged 1 commit into from
Sep 2, 2023

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Sep 2, 2023

deno only support x86 on linux

Signed-off-by: wuhuizuo wuhuizuo@126.com

deno only support x86 on linux

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind September 2, 2023 09:42
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 2, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
Summary:
The pull request fixes a cronjob issue in a Jenkins pipeline by adding a nodeSelector that specifies kubernetes.io/arch as amd64 because deno only supports x86 on Linux.

Potential problems:
There are no potential problems with the changes as they seem to be straightforward.

Fixing suggestions:
The changes proposed in the pull request seem to be reasonable and should not cause any problems. However, it would be good to have additional testing to ensure that the cronjob works correctly with the updated nodeSelector.

@ti-chi-bot ti-chi-bot bot added the size/XS label Sep 2, 2023
@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Sep 2, 2023

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 2, 2023
@ti-chi-bot ti-chi-bot bot merged commit bdcf255 into main Sep 2, 2023
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/deno-cron-job-arch-selector branch September 2, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant