Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/prod/tekton/configs/pipelines): fix demo pipeline #675

Merged
merged 1 commit into from
Sep 2, 2023

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Sep 2, 2023

Signed-off-by: wuhuizuo wuhuizuo@126.com

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind September 2, 2023 14:25
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 2, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
Pull Request Review:

The pull request makes the following changes:

  • Removes the workspaces section from the pipeline1.yaml file.

Potential problems:
It is difficult to assess the potential problems with such a small diff. However, there could be potential problems if the git-source workspace is used elsewhere in the pipeline.

Fixing suggestions:
If the git-source workspace is not used elsewhere in the pipeline, removing the workspaces section is a valid fix. Otherwise, the workspaces section should be modified to include the git-source workspace.

@ti-chi-bot ti-chi-bot bot added the size/XS label Sep 2, 2023
@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Sep 2, 2023

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 2, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 2, 2023
@ti-chi-bot ti-chi-bot bot merged commit 2322f0a into main Sep 2, 2023
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/pipeline1 branch September 2, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant