Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/prod/tekton/configs): fix building pipeline for artifacts repo #678

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Sep 5, 2023

No description provided.

@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind September 5, 2023 08:00
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 5, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.

Pull Request Review

Summary

This pull request aims to fix a building pipeline for the artifacts repo by adding a new params to the pull-pingcap-qe-artifacts-build-image.yaml file.

Changes Made

  • Added new params to pull-pingcap-qe-artifacts-build-image.yaml file.
  • Updated build-ci-base-arm64, build-ci-base-amd64, and mult-arch-push tasks in the same file.

Potential Problems

  • The pr description is empty. It would be better to include some details about the problem and why this solution was chosen.
  • The dockerconfig parameter is optional, but it is not clear whether it is mandatory or not. It would be better to clarify this in the description or in the comments.
  • There are some commented-out params in the file. It would be better to remove them or provide some explanation in the comments about why they are not used.

Suggestions

  • Add a description to the pr explaining what problem this change is addressing.
  • Clarify whether the dockerconfig parameter is mandatory or not.
  • Remove commented-out params or provide some explanation in the comments about why they are not used.

@ti-chi-bot ti-chi-bot bot added the size/L label Sep 5, 2023
@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Sep 5, 2023

/approve no-issue

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 5, 2023
@ti-chi-bot ti-chi-bot bot merged commit 18bc23b into main Sep 5, 2023
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/setup-artifacts-build-pipelines branch September 5, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant