Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/dev/prow/release): recude resources usage #681

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Sep 8, 2023

/approve

@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind September 8, 2023 19:32
@ti-chi-bot ti-chi-bot bot added the size/XXL label Sep 8, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 8, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.

Pull Request Review

Title: fix(apps/dev/prow/release): reduce resources usage

Description: /approve

Key Changes:

  • Added resource requests for CPU and memory in various components (crier, deck, ghproxy, tide, hook, horologium, pcm, pipeline, sinker, statusReconciler, jenkinsOperator, thirdPlugins).
  • Commented out the configurations for ti-community-autoresponder, ti-community-blunderbuss, ti-community-cherrypicker, ti-community-contribution, ti-community-format-checker, ti-community-issue-triage, ti-community-label, ti-community-label-blocker, ti-community-lgtm, ti-community-merge, ti-community-owners, ti-community-tars, and tichi-web.

Potential Problems:

  1. The resource requests for all the components are set to the same values (100m CPU and 250Mi memory), which might not be ideal for each component's actual resource requirements.
  2. Commenting out the configurations for several plugins may lead to those plugins not being available in the deployment, potentially breaking some functionality.

Fixing Suggestions:

  1. Evaluate the actual resource requirements for each component, and set the resource requests accordingly to avoid over or under allocation of resources.
  2. If the intention is to disable the plugins temporarily, consider adding a flag or environment variable to enable or disable them instead of commenting out their configurations. This would make it easier to maintain and toggle their status as needed.

@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Sep 8, 2023

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 8, 2023
@ti-chi-bot ti-chi-bot bot merged commit 8b29cb7 into main Sep 8, 2023
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/reduce-resource-usage branch September 8, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant