feat(apps/dev/tekton): enable tekton

[wuhuizuo]

Enable Tekton deployments

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary of Key Changes

1. Enabled Tekton deployments in apps/dev/kustomization.yaml.
2. Added tekton/ingress.yaml with Kustomization for Tekton ingress.
3. Moved ingress-dashboard.yaml from tekton/setup to tekton/ingress.
4. Added ingress-event-listener.yaml to tekton/ingress.
5. Uncommented - ingress.yaml in apps/dev/tekton/kustomization.yaml.
6. Updated apps/dev/tekton/setup.yaml with wait: true, images, and patches for namespace replacement and container resources.
7. Removed ingress-dashboard.yaml and pip-release.yaml from apps/dev/tekton/setup/kustomization.yaml.
8. Deleted apps/dev/tekton/setup/pip-release.yaml.

Potential Problems

1. In apps/dev/tekton/ingress.yaml, the path is set to ./apps/prod/tekton/ingress. It should be ./apps/dev/tekton/ingress since this is for the dev environment.

Fixing Suggestions

1. Update the path in apps/dev/tekton/ingress.yaml:

   spec:
     path: ./apps/dev/tekton/ingress

2. Verify that all necessary resources and configurations are in place for the new Tekton ingress setup. Ensure that appropriate access controls and security measures are implemented.

[wuhuizuo]

/approve

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• apps/OWNERS [wuhuizuo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[wuhuizuo]

/hold

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary of key changes:

1. Enabled Tekton in apps/dev/kustomization.yaml.
2. Modified path in apps/dev/tekton/configs.yaml from ./apps/staging/tekton/configs to ./apps/dev/tekton/configs.
3. Added a new file apps/dev/tekton/ingress.yaml.
4. Renamed apps/dev/tekton/setup/ingress-dashboard.yaml to apps/dev/tekton/ingress/ingress-dashboard.yaml.
5. Added a new file apps/dev/tekton/ingress/ingress-event-listener.yaml.
6. Added a new file apps/dev/tekton/ingress/kustomization.yaml.
7. Updated apps/dev/tekton/kustomization.yaml with an additional # - ingress.yaml.
8. Modified apps/dev/tekton/setup.yaml with new path, added wait: true, new image tag, patches for namespace replacement, and container resources.
9. Removed ingress-dashboard.yaml and pip-release.yaml from apps/dev/tekton/setup/kustomization.yaml.
10. Deleted the file apps/dev/tekton/setup/pip-release.yaml.

Potential problems:

1. In apps/dev/tekton/ingress.yaml, the secret tekton-ingress should be manually created in the apps namespace. If it's not created, it might cause issues.
2. In apps/dev/tekton/kustomization.yaml, the ingress.yaml is commented out. This might lead to issues if the ingress is expected to be created.

Fixing suggestions:

1. Verify if the secret tekton-ingress is created in the apps namespace. If not, create it manually.
2. Uncomment the ingress.yaml in apps/dev/tekton/kustomization.yaml if it's intended to be included.

resources:
  - setup.yaml
  - configs.yaml
  - ingress.yaml

[ti-chi-bot]

I have already done a preliminary review for you, and I hope to help you do a better job.

Pull Request Review

Title: feat(apps/dev/tekton): enable tekton

Description: Enable Tekton deployments

Key Changes:

1. Enabled Tekton in apps/dev/kustomization.yaml.
2. Updated the path in apps/dev/tekton/configs.yaml.
3. Added a new ingress configuration in apps/dev/tekton/ingress.yaml.
4. Moved ingress-dashboard.yaml from apps/dev/tekton/setup/ to apps/dev/tekton/ingress/.
5. Added a new ingress configuration for event listener in apps/dev/tekton/ingress/ingress-event-listener.yaml.
6. Created a new kustomization file in apps/dev/tekton/ingress/kustomization.yaml.
7. Updated the kustomization file in apps/dev/tekton/kustomization.yaml.
8. Updated the setup file in apps/dev/tekton/setup.yaml.
9. Removed pip-release.yaml in apps/dev/tekton/setup/.
10. Updated the kustomization file in apps/dev/tekton/setup/kustomization.yaml.

Potential Problems:

1. In the apps/dev/tekton/kustomization.yaml, there is a commented line with a FIXME note regarding assigning the same IP address to multiple Ingress resources in GKE.

Fixing Suggestions:

1. For the FIXME note, consider using a single Ingress resource with multiple paths or using different IP addresses for each Ingress resource. Check the GKE documentation for any specific guidelines on handling multiple Ingress resources.

[wuhuizuo]

/unhold