Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/prod/jenkins/release): bump jenkins controller and plugins #697

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Oct 5, 2023

  • tested in beta instance.

@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind October 5, 2023 19:23
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 5, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
Summary:
The pull request is about bumping Jenkins controller and plugins. The changes include removing installPlugins flag, adding cloudevents plugin configuration, and updating plugin versions.

Potential problems:
It's not clear why the installPlugins flag was removed. The cloudevents plugin configuration may not work as expected if the issue with the cdevents plugin isn't resolved. The updated plugin versions may introduce breaking changes and need to be tested.

Fixing suggestions:
It would be good to add a comment explaining why the installPlugins flag was removed. If the cloudevents plugin configuration is critical, it may be worth waiting until the cdevents plugin issue is resolved. The updated plugin versions should be tested in a staging environment before deploying to production.

@ti-chi-bot ti-chi-bot bot added the size/M label Oct 5, 2023
@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Oct 5, 2023

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 5, 2023
@ti-chi-bot ti-chi-bot bot merged commit 31c36a7 into main Oct 5, 2023
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the feature/bump-apps-prod-jenkins branch October 5, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant