Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/prod/jenkins/release): bump bfa plugin #699

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Oct 7, 2023

Update with upstream to fix security issues.

Tests:

Update with upstream to fix security issues.
@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind October 7, 2023 05:55
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 7, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
Summary:

The pull request is updating the build-failure-analyzer plugin version from v2.4.1 to v2.4.2 in the values-controller-plugins.yaml file. The reason for the update is to fix security issues.

Potential Problems:

It seems there are no potential problems in this pull request. The changes are minimal and straightforward, and the reason for the update is well-defined.

Fixing Suggestions:

As there are no potential problems, there is no need for fixing suggestions. The pull request can be approved.

@wuhuizuo
Copy link
Collaborator Author

wuhuizuo commented Oct 7, 2023

/hold

We should merge it in maintenance window.

@wuhuizuo
Copy link
Collaborator Author

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 20, 2023
@wuhuizuo
Copy link
Collaborator Author

/unhold

@ti-chi-bot ti-chi-bot bot merged commit e8c670a into main Oct 20, 2023
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/apps/prod/bump-jenkins-plugin-bfa branch October 20, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant