Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apps/gcp): fix prowjob crd #703

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Conversation

wuhuizuo
Copy link
Collaborator

@wuhuizuo wuhuizuo commented Oct 8, 2023

Why

The validation of tekton pipeline spec is wrong, and is not fixed in prow upstream.

but here has a fixed version: https://github.com/kyma-project/test-infra/raw/main/prow/cluster/components/prowjob_customresourcedefinition.yaml

Tests

  • We have tested it in prow-dev.tidb.net instance

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested a review from jayl1e October 8, 2023 17:57
@ti-chi-bot ti-chi-bot bot added the area/apps label Oct 8, 2023
@ti-chi-bot ti-chi-bot bot requested a review from purelind October 8, 2023 17:57
@ti-chi-bot ti-chi-bot bot added the env/GCP will deploy on GCP cluster label Oct 8, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 8, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.
Based on the pull request title and description, it seems like the change is related to the prowjob crd in the apps/gcp directory. The change is in the prow-crd.yaml file where the path has been changed from ./apps/_crds/prow to ./apps/_crds/prow/hacked. This change implies that there is a new directory hacked that includes the necessary files for the prowjob crd.

One potential problem with this change is that it may affect the build process of the project if the files in the new directory hacked are not compatible or incorrect. Therefore, it is essential to ensure that the files in the new directory are correct, and the build process can successfully complete with the new changes.

Some suggestions for fixing this could be to test the build process with the new changes and ensure that it completes successfully without any issues. Additionally, it would be helpful to update the documentation or readme file to reflect the changes made so that other developers can be aware of the new directory and its contents.

@ti-chi-bot ti-chi-bot bot added the size/XS label Oct 8, 2023
@wuhuizuo
Copy link
Collaborator Author

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 14, 2023
@ti-chi-bot ti-chi-bot bot merged commit c5dec9e into main Oct 14, 2023
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/apps/gcp/prow-crd-about-tekton branch October 14, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant