Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apps/prod/tekton/config/triggers): add triggers for pingcap-qe/artifacts #708

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

wuhuizuo
Copy link
Collaborator

  • branch pushing.
  • branch creating.
  • tag creating.

…artifacts`

- branch pushing.
- branch creating.
- tag creating.

Signed-off-by: wuhuizuo <wuhuizuo@126.com>
@ti-chi-bot ti-chi-bot bot requested review from jayl1e and purelind October 18, 2023 17:42
@ti-chi-bot ti-chi-bot bot added area/apps env/prod will deploy on the main product cluster size/XL labels Oct 18, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 18, 2023

I have already done a preliminary review for you, and I hope to help you do a better job.

Pull Request Summary

Title: feat(apps/prod/tekton/config/triggers): add triggers for pingcap-qe/artifacts

Description:

- branch pushing.
- branch creating.
- tag creating.

Key Changes

  1. Added new trigger bindings for GitHub branch create, branch push, and tag create events.
  2. Modified the existing pull request trigger binding to include more params like pr-title and pr-body.
  3. Updated the event listener to handle branch push, branch create, and tag create events.
  4. Created new trigger templates for branch create, branch push, and tag create events.
  5. Added new triggers for branch create, branch push, and tag create events.

Potential Problems

  1. The event listener might not be configured properly for the new events (branch push, branch create, and tag create).
  2. The new trigger templates might not be compatible with the existing pipeline.

Suggestions

  1. Double-check the event listener configuration and ensure it's properly set up for the new events.
  2. Test the new trigger templates with the existing pipeline to ensure compatibility.

Please let me know if there are any concerns or if you need further assistance with the review.

@wuhuizuo
Copy link
Collaborator Author

/approve

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Oct 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 18, 2023
@ti-chi-bot ti-chi-bot bot merged commit 78a3cf1 into main Oct 18, 2023
4 checks passed
@ti-chi-bot ti-chi-bot bot deleted the ci/add-triggers-for-artifacts-repo branch October 18, 2023 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/apps env/prod will deploy on the main product cluster size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant