-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Japanese translation patch (Update ja.yml) #672
base: master
Are you sure you want to change the base?
Conversation
My guess is that such mistranslations occurred in large numbers because English and Japanese grammar are very different. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial correction. This should be mostly ok.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
気になったところをコメントしました。
全ては見ていません。
I commented on what I was interested in.
I didn't see all of them.
Co-authored-by: waxsd100 <12383342+waxsd100@users.noreply.github.com>
Co-authored-by: waxsd100 <12383342+waxsd100@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waxsd100さん、修正提案ありがとうございます!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ごめん何個か見逃してた。
他にもトランザクションと入れ替えとか色々混ざってる気がするがそこはスルーします。
(気が向いたときにゲーム内確認してこっちで直します)
修正した内容はLGTM
Co-authored-by: waxsd100 <12383342+waxsd100@users.noreply.github.com>
Co-authored-by: waxsd100 <12383342+waxsd100@users.noreply.github.com>
Co-authored-by: waxsd100 <12383342+waxsd100@users.noreply.github.com>
Co-authored-by: waxsd100 <12383342+waxsd100@users.noreply.github.com>
Co-authored-by: waxsd100 <12383342+waxsd100@users.noreply.github.com>
ありがとうございます🙇 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Intelli please review This pull request includes various updates and improvements to the Japanese localization file Key updates and improvements:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Intelli Please merge and review.
Fixed some translations that were still incomplete as of the last issue (#660).
However, please note that they may be incomplete.