Fix hang in PreviousEffect() (issue #583)
#584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davepl
approved these changes
Jan 3, 2024
revision29
added a commit
to revision29/NightDriverStrip
that referenced
this pull request
Feb 8, 2024
commit 2bc036d706e661305c8fbbdc4d73224e62949707
Author: Joe Schneider <joe@revision29.com>
Date: Thu Feb 8 14:06:37 2024 -0500
Renamed Files
I have renamed my custom remote files so they get pushed to GitHub. Modified remotecontrol.cpp to include the newly renamed custom remote file(s).
commit 514b6e008ae4255e3488dcf121d9054433015677
Merge: 354e3975 20c7c3ac
Author: Joe Schneider <joe@revision29.com>
Date: Mon Jan 29 21:47:09 2024 -0500
Merge branch 'PlummersSoftwareLLC:main' into PersonalProjects
commit 20c7c3acf03fe9d87deb02c82144545dbc05ef1e
Merge: 83f67184 249d59a1
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Fri Jan 26 19:13:58 2024 +0100
Merge pull request #599 from rbergen/fix-596
Move Improv announcement from setup to loop
commit 249d59a142b139604d47a8a7a36ad40b4b57d7ad
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Thu Jan 25 09:49:56 2024 +0100
Move Improv announcement from setup to loop
commit 83f67184f329f82ce36abad2b4406a38fa0b4369
Merge: cbc933c4 f7aac2c7
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sat Jan 20 12:03:59 2024 +0100
Merge pull request #595 from PlummersSoftwareLLC/dependabot/npm_and_yarn/site/vite-4.5.2
Bump vite from 4.5.1 to 4.5.2 in /site
commit f7aac2c7576b278fe6f017676611a90c2f1f6365
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Sat Jan 20 09:37:57 2024 +0000
Bump vite from 4.5.1 to 4.5.2 in /site
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 4.5.1 to 4.5.2.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v4.5.2/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v4.5.2/packages/vite)
---
updated-dependencies:
- dependency-name: vite
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
commit cbc933c4df9d1744728a0c02fc2ae2251f4a9981
Merge: ee26c344 665efaf2
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Tue Jan 16 08:58:48 2024 +0100
Merge pull request #590 from davepl/main
Memory Stuff
commit 665efaf2dfb92a5f1116a78aa960653c616dcbc5
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Mon Jan 15 20:08:45 2024 +0100
Clear trailing spaces
commit 28c072b10d18d06d9e374fa36ff0d677e83ae219
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Mon Jan 15 20:06:49 2024 +0100
Set effect set version for M5DEMO
commit 16d853f843efb53e070cb2380ca92939e9ec0456
Author: Dave Plummer <dave@MacStudio.local>
Date: Sat Jan 13 10:41:39 2024 -0800
Fix RNG
commit 7577c8f80120cc8742082d4799a152d87623974f
Merge: 0f1d4325 ee26c344
Author: David W Plummer <davepl@davepl.com>
Date: Sat Jan 13 09:36:57 2024 -0800
Merge branch 'PlummersSoftwareLLC:main' into main
commit ee26c34429cd132b6a11cedaa9a227b88b51cd2a
Merge: 850aba4a dcb6a76a
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Wed Jan 10 12:43:25 2024 +0100
Merge pull request #587 from rbergen/Reenable-Fanset-networking
Re-enable Fanset networking, move TTGO in web installer
commit 0f1d43259277e6a772e3bdcefe8c0b27f2ef008c
Author: Dave Plummer <dave@MacStudio.local>
Date: Tue Jan 9 19:13:50 2024 -0800
Memory work
commit dcb6a76a62fe5ba5baa1a069828b9fdc6c0ed8a1
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Tue Jan 9 12:45:21 2024 +0100
Move TTGO project to its own device
commit 3de99a1fbed76087b220e92ca3cb98d86b4b86b7
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Tue Jan 9 11:44:13 2024 +0100
Enable Fanset WiFi and webserver
commit 94a5b25c4172b20436c347385c1e4657b2070ec5
Author: Dave Plummer <dave@MacStudio.local>
Date: Wed Jan 3 18:22:05 2024 -0800
Fix Star effect
commit a4519e91abaf29f888dc40a70fa4b6001a0dd363
Author: Dave Plummer <dave@MacStudio.local>
Date: Wed Jan 3 18:07:31 2024 -0800
Remove build info
commit 919e1a62022d0ca9bc04a0159a72150e4b45fe68
Author: Dave Plummer <dave@MacStudio.local>
Date: Wed Jan 3 18:06:36 2024 -0800
Fix Axp issue
commit f5057e33cb4e3a6e3d484e5b332c12103ae0c049
Author: Dave Plummer <dave@MacStudio.local>
Date: Wed Jan 3 17:57:29 2024 -0800
M5 Stack Core 2 Demo
commit a3bac3e645b37351a3fdad4178d156dade76fac8
Author: Dave Plummer <dave@MacStudio.local>
Date: Wed Jan 3 17:56:15 2024 -0800
M5 SStack Core 2 Demo
commit 850aba4ae1cd02da395eddb39bd3b710ff1d7c8e
Merge: 71af2306 809afad9
Author: David W Plummer <davepl@davepl.com>
Date: Wed Jan 3 15:18:32 2024 -0800
Merge pull request #584 from rbergen/fix-583
Fix hang in `PreviousEffect()` (issue #583)
commit 809afad9f8b3bdaa7f822a10bc5427d213d9defe
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Wed Jan 3 13:15:11 2024 +0100
Fix #583
commit 354e3975a869caac73ef8644c2da173e9d5eba7e
Merge: e522294d 71af2306
Author: Joe Schneider <joe@revision29.com>
Date: Wed Dec 27 10:26:54 2023 -0500
Merge branch 'PlummersSoftwareLLC:main' into PersonalProjects
commit 71af2306f22a0e8c2d51982a17057b9cfefab906
Merge: 3b9ed020 68be464d
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sun Dec 24 17:41:14 2023 +0100
Merge pull request #573 from rbergen/fix-fanset
Update two M5StickC Plus configurations and ESP Web Tools
commit 3b9ed0208b0132582daaac87b8446faa7604a98c
Merge: a6649694 d6178bdc
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sun Dec 24 16:48:03 2023 +0100
Merge pull request #575 from PlummersSoftwareLLC/dependabot/npm_and_yarn/site/vite-4.5.1
Bump vite from 4.5.0 to 4.5.1 in /site
commit d6178bdcd5a8fbc1f0ad6283057be113c7787e09
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date: Sun Dec 24 15:20:39 2023 +0000
Bump vite from 4.5.0 to 4.5.1 in /site
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 4.5.0 to 4.5.1.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v4.5.1/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v4.5.1/packages/vite)
---
updated-dependencies:
- dependency-name: vite
dependency-type: direct:development
...
Signed-off-by: dependabot[bot] <support@github.com>
commit 68be464d10d0e290ed00d0f335f71c355bc71978
Merge: 34ae90d3 a6649694
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sun Dec 24 16:18:07 2023 +0100
Merge remote-tracking branch 'upstream/main' into fix-fanset
commit a66496945342d965bd8bac9b8149e1909f70d3c3
Merge: e7fa318b ed497532
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sun Dec 24 16:17:41 2023 +0100
Merge pull request #574 from robertlipe/ythislever
Make secrets.h more immune to changes from secrets.example.h
commit 34ae90d34052b3b8a04acf29d7924011104d87a5
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sun Dec 24 16:10:53 2023 +0100
Make ESP Web Tools wait another 5 seconds
commit ed497532f26371fd51bb92d59f287b945c4517e2
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sun Dec 24 16:09:04 2023 +0100
Textual updates
commit c92e39ea39fd885dbee2686ad7b0ad383d4696cd
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sun Dec 24 14:48:36 2023 +0100
Blindly declare presence
commit 549907bced7a1db92c71650b794572c7d4cb56ca
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sun Dec 24 13:33:34 2023 +0100
Update ESP Web Tools with correct files
commit 3b9a7656625e8af7c74652927190d9b7bdab6494
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sun Dec 24 13:23:11 2023 +0100
Update Spectrum config
commit 9c052695e79d4f493518c752539b25bc55b80744
Author: Robert Lipe <robertlipe@gmail.com>
Date: Sun Dec 24 05:13:42 2023 -0600
Make secrets.h more immune to changes from secrets.example.h
When new fields are added in the example file, add a test in the
file that uses the real file to be sure the fields are present. This
is to solve the case where a developer has a checked-out, working tree
with a working secrets.h, syncs to head or another branch that adds
fields in secrets, and then incurs weird compilation errors when those
new fields aren't found.
This change leads the developer to the correct file and the doc
describing it for a better experience.
commit 4e0ef987451b34cd31b0deaa09221bb45cb4d00f
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sun Dec 24 10:35:37 2023 +0100
Disable WiFi to save RAM
commit 2cac1000848c416b231eae1b363089322c6ee37c
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sat Dec 23 21:19:38 2023 +0100
Update ESP Web Tools
commit f5c920727d95b581e60f0fc97025af6ae2cfc884
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sat Dec 23 20:40:30 2023 +0100
Show color data server
commit 00041113318a2eb06d593f0332e5fc1c1ed3c876
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sat Dec 23 19:21:16 2023 +0100
Remove improper division on deserialization
commit 2699189c55e5b073f0a4ff0d694d71be1275d048
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sat Dec 23 17:44:17 2023 +0100
Explicitly clear JsonDocuments
commit 837e30a8bef3cd7d2d5de1648fdd5b951f15a301
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sat Dec 23 17:08:13 2023 +0100
Reduce MAX_BUFFERS
commit 5948b0c7f4a07b10581234b5e8a50c96430d932f
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sat Dec 23 13:24:26 2023 +0100
Disable services to prevent OOM reboots
commit e522294dd7ddec55b2bc581af9b0dd8e4c0adf9c
Merge: 1f2801b0 e7fa318b
Author: Joe Schneider <joe@revision29.com>
Date: Fri Dec 22 21:30:23 2023 -0500
Merge branch 'PersonalProjects' of https://github.com/revision29/NightDriverStrip into PersonalProjects
commit e7fa318b4bfbeb76cbbbdec5ca0f870a74da4a68
Merge: 694d8760 63f5eee9
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sat Dec 16 20:50:55 2023 +0100
Merge pull request #570 from davepl/main
Add Firelog effect, move screen drawing to core 1
commit 63f5eee938a77ce67b33e0aba268fd1e9b36a77e
Author: Dave Plummer <dave@MacStudio.local>
Date: Sat Dec 16 10:33:32 2023 -0800
Remove psram from m5demo
commit f1bc878b5dfa1ca424e5255a85b675a7573d0526
Author: Dave Plummer <dave@MacStudio.local>
Date: Sat Dec 16 10:32:47 2023 -0800
Fix m5demo
commit b7cbe2920ee39a92ec6dc4b11a7bde940a84dfa4
Merge: c9220320 694d8760
Author: David W Plummer <davepl@davepl.com>
Date: Sat Dec 16 10:29:07 2023 -0800
Merge branch 'PlummersSoftwareLLC:main' into main
commit c922032014733723613e80afd8c1356ddf366189
Author: Dave Plummer <dave@MacStudio.local>
Date: Sat Dec 16 10:26:47 2023 -0800
Add Fire log
commit 694d876047678e0eeae9970dd2d709534044e38c
Merge: d4d6abf0 1cb041e8
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sat Dec 16 14:39:34 2023 +0100
Merge pull request #563 from davepl/main
Add nycancat, palette support for hypnosis
commit 1cb041e8ea43dc6aea2396baf598e8ff18ab64d1
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Tue Dec 12 12:47:30 2023 +0100
Fix comment typos
commit 015d346b2e4586419ad8ba0412b512b6145a3c1e
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Mon Dec 11 18:28:33 2023 +0100
Restore effect interval to previous value
commit f62ca3ec26e494405df74b8af0778d99dae130b0
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Mon Dec 11 17:40:08 2023 +0100
Make debugV a debugI
commit aba1688b3b4dd9fc9462c637acb94aea8bbf5e55
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Mon Dec 11 09:45:22 2023 +0100
Apply suggestions
commit 960daf5077f52297fa1bab0af5441c8985bbbbea
Author: Dave Plummer <dave@MacStudio.local>
Date: Sun Dec 10 14:39:25 2023 -0800
Fire log and fix pixel counts
commit 776b7a9aef7a6d4ca9c4056a7ed391faea5d6589
Author: Dave Plummer <dave@MacStudio.local>
Date: Sun Dec 10 14:39:13 2023 -0800
Fix wifpixelcount, add fire log
commit 9ff5bae201d8c1ab0645857e0f2efd651bd81779
Author: Dave Plummer <dave@MacStudio.local>
Date: Fri Dec 8 17:14:27 2023 -0800
Undo reversion of c++ version
commit 1f2801b069faa09e2851cbda989a98c6f4637535
Author: Joe Schneider <joe@revision29.com>
Date: Fri Dec 8 16:25:12 2023 -0500
Troubleshooting
Setting a temp effect is not working. Effect manager does not draw it appropriately. Trying different options to get one to display properly.
commit da7804f89f93be1548f41d92443151510f6ca7b0
Author: Joe Schneider <joe@revision29.com>
Date: Thu Dec 7 22:46:58 2023 -0500
added debug code
commit 983a0d5315fd26592f33eedbb31648df94deb61c
Author: Joe Schneider <joe@revision29.com>
Date: Thu Dec 7 20:35:02 2023 -0500
Removed more custom code
commit aad0193b830469ee2920a6188b79d68c57b44918
Author: Joe Schneider <joe@revision29.com>
Date: Thu Dec 7 16:23:27 2023 -0500
added code to insert custom IR remote code
commit 372a80980cf9b393cad3728cfa227a0c0af051f3
Author: Joe Schneider <joe@revision29.com>
Date: Thu Dec 7 16:13:03 2023 -0500
Reverted some changes, added labels
After closing the PR, I am now working to bring my personal projects into this fork as a stable branch. Other branches will be pruned.
Reverted changes to remote code since I will be including my own remote code.
commit fb039fa7d37e15db70cdf685869f81c19da6f3d2
Merge: 329a347a d4d6abf0
Author: Joe Schneider <joe@revision29.com>
Date: Thu Dec 7 16:06:25 2023 -0500
Merge branch 'PlummersSoftwareLLC:main' into PersonalProjects
commit b57509c4d0f69b8da6fe50f42352016b820e5f36
Author: Dave Plummer <dave@MacStudio.local>
Date: Thu Dec 7 10:27:12 2023 -0800
Change to Ofast
commit 8ff01861c223d27ea63244be3d2fc12adc60cfcf
Author: Dave Plummer <dave@MacStudio.local>
Date: Thu Dec 7 10:13:23 2023 -0800
Fix M5Demo mem usage
commit 9b139d430acc382c54e260d11b2d4eadde2ca9b8
Author: Dave Plummer <dave@MacStudio.local>
Date: Thu Dec 7 09:46:13 2023 -0800
Add skip frame support
commit 6c112a3c29e91ada9616cd15e06f2d0baf12330f
Author: Dave Plummer <dave@MacStudio.local>
Date: Thu Dec 7 09:24:28 2023 -0800
Fix m5demo
commit 29794fbc7f5373ef8cc9ab0fcf295dd1e5c53532
Merge: 3dabfdba f93c65eb
Author: Dave Plummer <dave@MacStudio.local>
Date: Thu Dec 7 09:16:40 2023 -0800
Merge branch 'main' of github.com:davepl/NightDriverStrip
commit 3dabfdbaff7eebe106a4862da48e7a825f4132df
Author: Dave Plummer <dave@MacStudio.local>
Date: Thu Dec 7 09:16:35 2023 -0800
Fix color
commit f93c65eb632db0ba96a327c6093699c600550df3
Merge: 4ad2fa79 d4d6abf0
Author: David W Plummer <davepl@davepl.com>
Date: Thu Dec 7 09:11:48 2023 -0800
Merge branch 'PlummersSoftwareLLC:main' into main
commit 4ad2fa79444713b45b988094cfc490840bb18f9f
Author: Dave Plummer <dave@MacStudio.local>
Date: Thu Dec 7 09:11:27 2023 -0800
Add nyancat, palette support
commit d4d6abf06ecc088e86e17b966db0e4de247d19d4
Merge: 518a2568 5a8a5832
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Wed Dec 6 10:17:33 2023 +0100
Merge pull request #549 from robertlipe/ports
Centralize port numbers in source
commit 518a2568f75f8b8dd9c1ce7c388fce44ec01a50a
Merge: c2bf4a97 083576a0
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Tue Dec 5 23:46:36 2023 +0100
Merge pull request #558 from mggates39/feature/Weather_Clean_Up_API_Key_Errors
Refactor Weather API Function Calls
commit 083576a0c05eb7abde589fd5db18426c263b183e
Merge: 511d8be8 c2bf4a97
Author: Marshall G. Gates <mggates@gmail.com>
Date: Tue Dec 5 15:55:41 2023 -0500
Merge remote-tracking branch 'upstream/main' into feature/Weather_Clean_Up_API_Key_Errors
commit 511d8be8e689fecb3f22b7f487b130d8da3cb256
Author: Marshall G. Gates <mggates@gmail.com>
Date: Tue Dec 5 15:23:43 2023 -0500
Corrected typo in variable name
commit c2bf4a97d674101cd9a8aeba9be49363f1151143
Merge: eac9ba69 ce3599ca
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Tue Dec 5 16:46:01 2023 +0100
Merge pull request #560 from robertlipe/20
Bump to C++2a
commit 35decdc56e222c71ed30ce7a918edb78021d7298
Author: Marshall G. Gates <mggates@gmail.com>
Date: Tue Dec 5 08:44:13 2023 -0500
Address issues in code review
- Made all rfeturn comments consistant
commit bbd59d04e74ab9406163fef1aa6fe0fbc8631e06
Author: Dave Plummer <dave@MacStudio.local>
Date: Sun Dec 3 20:03:19 2023 -0800
Fix build
commit 35ceaa68fba0b0f2c428d7055e9e226d0d6ded86
Author: Dave Plummer <dave@MacStudio.local>
Date: Sun Dec 3 17:54:42 2023 -0800
Add tesseract, instructions
commit 7f33cf0a48a4f05f168e2f1678e5daf4fc2d1eb8
Author: Marshall G. Gates <mggates@gmail.com>
Date: Sun Dec 3 14:50:22 2023 -0500
Refactor HasLocationChanged
Remove unnecessary String creation and deletion
commit 0f0877e38950c5681ab4a76a0b67d7696351c550
Author: Marshall G. Gates <mggates@gmail.com>
Date: Sun Dec 3 14:49:36 2023 -0500
Revert changes as requested
- Ensure all methods only have one exit point is a style change in already working code.
commit 583e9a4ecaf2404e7eae55ef244c6dbdbfc4c91a
Author: Marshall G. Gates <mggates@gmail.com>
Date: Sun Dec 3 14:34:50 2023 -0500
Cleaned up poorly named variable
commit eac9ba69ec1740516875b6c06f4f450f8878896f
Merge: f61b5611 597031d2
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sun Dec 3 09:17:23 2023 +0100
Merge pull request #556 from davepl/main
Fix fire perf, protect against possible GIF load failure
commit 538c782f348015f09e8e8104f752c01031aaa3fd
Author: Marshall G. Gates <mggates@gmail.com>
Date: Sat Dec 2 22:24:33 2023 -0500
Refactor API Function Calls
- Ensure all API Calls are only done if API Key is present
- Ensure all methods only have one exit point
- Improve Debug message levels to match actual state
- Add improved method level comments
commit 329a347a57c1f096b938e483bd7008b9bf7d5bb7
Author: Joe Schneider <joe@revision29.com>
Date: Fri Dec 1 18:11:27 2023 -0500
Removed outdated method call
Since effect manager no longer displays a temporary effect when ApplyGlobalColor is true, the call to deviceConfig.ApplyGlobalColors() is not needed.
We do want next and previous effect buttons to stop displaying a temp effect if one is active.
commit 597031d2233bf56bda959f25b165764de4267148
Author: Dave Plummer <dave@MacStudio.local>
Date: Fri Dec 1 13:29:45 2023 -0800
Fix fire perf and protect against GIF load failure
commit d6104daaef0269f88e1b30c04755c094949186fd
Author: Dave Plummer <dave@MacStudio.local>
Date: Fri Dec 1 12:05:19 2023 -0800
Guard against failed GIF load
commit f61b5611b5edfe9881c9435f55055e78acfdf045
Merge: f6e1fb0a 5d383761
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Fri Dec 1 17:49:10 2023 +0100
Merge pull request #553 from davepl/EffectTable
Fix animated GIF effects
commit 5d3837619a9aff8eba00e1db6c05ff3d50b64939
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Fri Dec 1 17:35:22 2023 +0100
Reenable animated GIF effects
commit cc3107a12472f8f501a330bbd4120c8955957a55
Merge: 8ff2a787 f6e1fb0a
Author: David W Plummer <davepl@davepl.com>
Date: Fri Dec 1 07:36:13 2023 -0800
Merge pull request #49 from PlummersSoftwareLLC/main
Update fork
commit 8ff2a787606491e46f0187fc9b4722063ea23445
Author: Dave Plummer <davepl@davepl.com>
Date: Fri Dec 1 15:35:06 2023 +0000
Fix uninit GIF var with fork
commit f6e1fb0a6ea3cd394a5204008f37eec5ad1f5032
Merge: a0ff1300 c3ee5476
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Fri Dec 1 15:19:40 2023 +0100
Merge pull request #551 from revision29/ColorFillEffectTweak
Added logic to optionally include external globals config file
commit 623a2433252b9b025b3b5737b9f6ad5b77ccd07d
Author: Joe Schneider <joe@revision29.com>
Date: Fri Dec 1 08:50:25 2023 -0500
Remote logic to clear temp effect
commit 2baba8ed691025da258631b90e1c90fb34e53a74
Author: Joe Schneider <joe@revision29.com>
Date: Fri Dec 1 08:42:48 2023 -0500
Added temp effect use case
The IR code should not assume audio is enabled.
Added logic to handle cases where IR is enabled, but audio is disable. Populates a temporary effect if audio is disabled isntead of showing the VU.
commit c3ee5476b37123e4bb2628791b31d225aebae4c9
Author: Joe Schneider <joe@revision29.com>
Date: Thu Nov 30 21:37:23 2023 -0500
removed extra new line at end of file
I tried to remove the newline via the GH web interface but it didn't show a line 26.
commit 7241008d762673831c253c74fd4b36cd9ce8db14
Author: Joe Schneider <joe@revision29.com>
Date: Thu Nov 30 19:37:02 2023 -0500
Update .gitignore
Removed recursive directory exclusion
commit a0ff13006f8b3f9820173ec5a71ea4f3e4279f5c
Merge: 96273bd4 763f82c6
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Fri Dec 1 00:59:22 2023 +0100
Merge pull request #548 from mggates39/feature/Weather-Fix-Tomorrow-Temps
Feature/weather fix tomorrow temps
commit 763f82c66f7b99ba38ac1a96c83dba92c66a40eb
Author: Marshall G. Gates <mggates@gmail.com>
Date: Thu Nov 30 17:45:36 2023 -0500
Addressed Code Review Comments
commit 5d7de96c26974c9c347eaee150a53bf181f8bfbb
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Thu Nov 30 22:33:50 2023 +0100
Load animated GIF effect in disabled state
commit 32e852955537417c3bda4e0eccbcb1e3ce0c9359
Merge: 4460f7c2 96273bd4
Author: David W Plummer <davepl@davepl.com>
Date: Thu Nov 30 13:20:29 2023 -0800
Merge branch 'main' into EffectTable
commit 96273bd4038bd245733fb259705ee7b051d60602
Merge: 2ad1fabc 6c1643e0
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Thu Nov 30 22:14:58 2023 +0100
Merge pull request #555 from rbergen/disable-animated-gifs
Add Animated GIFs in disabled state
commit 6c1643e0042fc0b3a1ac4a5e577cc848b885d449
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Thu Nov 30 22:04:32 2023 +0100
Remove duplicate Colorball
commit ce3599caabe6a983d081c0e6be77e6164f93724d
Author: Robert Lipe <robertlipe@gmail.com>
Date: Thu Nov 30 14:56:36 2023 -0600
Bump to C++2a
commit 0b4f9a0379e75eede52c347cc83b721e3771fe60
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Thu Nov 30 21:55:11 2023 +0100
Add Animated GIFs in disabled state
commit 358b68ca574873cd64044b9d3da4f76002f3211f
Author: Joe Schneider <joe@revision29.com>
Date: Thu Nov 30 14:46:49 2023 -0500
One more tweak to platoformio.ini
Changed to allow loading multiple configs that start with `custom_`
commit 5fc8ba17878d267cd83355bd91d9dedbf082140a
Author: Joe Schneider <joe@revision29.com>
Date: Thu Nov 30 14:39:16 2023 -0500
Changed platoformio include name
custom makes more sense than user.
commit 4460f7c238067441895317bf6b7df0f9592b2b00
Author: Dave Plummer <dave@MacStudio.local>
Date: Thu Nov 30 11:24:51 2023 -0800
Rework animated GIF loading
commit 7100082b6d466af7dab2ad842691bdcba78906c4
Author: Dave Plummer <dave@MacStudio.local>
Date: Thu Nov 30 10:01:53 2023 -0800
"Fix" animated gif crash
commit f5673a653373682c82923bc1f2001c9675a1f79a
Author: Joe Schneider <joe@revision29.com>
Date: Thu Nov 30 08:15:21 2023 -0500
slight change to go along with last commit
commit 899393ac909dc8a12bfb7f5e87f4ad32d33752dd
Author: Joe Schneider <joe@revision29.com>
Date: Thu Nov 30 08:14:43 2023 -0500
slight variable name change
commit 173e522942623b4d0db9368524bed87f186bab39
Author: Joe Schneider <joe@revision29.com>
Date: Thu Nov 30 08:11:50 2023 -0500
Small adjustments
Added entries in .gitignore to ignore user configuration files.
Also added line in platformio.ini to include an external config file. If the file does not exist, platformio ignores it. If it does exist, it will read from it. No logic necessary.
commit ac4a9b05fc684779d3dba65ede49680e8654e9ce
Author: Joe Schneider <joe@revision29.com>
Date: Thu Nov 30 08:06:02 2023 -0500
Revert "Added entries to ignore custom files"
This reverts commit e57c457153837a74f0c98fc8f4e2a34f458ab9c2.
commit e57c457153837a74f0c98fc8f4e2a34f458ab9c2
Author: Joe Schneider <joe@revision29.com>
Date: Thu Nov 30 07:59:52 2023 -0500
Added entries to ignore custom files
Ignores custom user files for:
- platoformio
- globals
- effects
commit 437fb203ce3ba8a14cb98660d97124722f10de43
Author: Dave Plummer <dave@MacStudio.local>
Date: Wed Nov 29 20:26:39 2023 -0800
Reorder effects table
commit 0b6827db548afba8d60229bb442bac68eb90c630
Author: Joe Schneider <joe@revision29.com>
Date: Wed Nov 29 21:39:50 2023 -0500
Fixed comments
commit 067fbc27a00adaba404939610c899da3a69ca935
Author: Joe Schneider <joe@revision29.com>
Date: Wed Nov 29 21:38:33 2023 -0500
Shortened method names
commit 46e33f53f261f857a95c3a4eb6b25e6faafeee15
Author: Joe Schneider <joe@revision29.com>
Date: Wed Nov 29 21:31:33 2023 -0500
Fixed build file changes
commit 2549e7a1c92c9726a86076c48b79a9b6dcc827d3
Author: Joe Schneider <joe@revision29.com>
Date: Wed Nov 29 21:29:57 2023 -0500
Revert "Added HasTemporaryEffect method"
This reverts commit edd17a804e103223ac4f93e08f331c15b16a626d.
commit edd17a804e103223ac4f93e08f331c15b16a626d
Author: Joe Schneider <joe@revision29.com>
Date: Wed Nov 29 21:26:50 2023 -0500
Added HasTemporaryEffect method
Added a method to check for _tempEffect.
commit 6c5b3ee71d755a9ff90cbe349a79a1608ef63c81
Author: Joe Schneider <joe@revision29.com>
Date: Wed Nov 29 21:18:11 2023 -0500
Created methods for handling temporary effects.
- Sets temporary effect.
- Clears temporary effect.
commit 33845b49a13cd86f83a32f4afc1f78566588f167
Merge: c393143d 2ad1fabc
Author: Joe Schneider <joe@revision29.com>
Date: Wed Nov 29 20:42:02 2023 -0500
Merge branch 'ColorFillEffectTweak' of https://github.com/revision29/NightDriverStrip into ColorFillEffectTweak
commit c393143d7ef423f2546590a578713df919e589a0
Author: Joe Schneider <joe@revision29.com>
Date: Wed Nov 29 20:41:52 2023 -0500
Create logic to include optional custom_globals.h
Checks for the existence of `custom_globals.h`. This file can include logic to select user specified projects instead of cluttering globals.h
commit 2ad1fabc3dd8ff04ce1ea7fcc5b6669e2c9c7a37
Merge: bc51da05 7d11c9c1
Author: David W Plummer <davepl@davepl.com>
Date: Wed Nov 29 16:23:57 2023 -0800
Merge pull request #550 from davepl/AnimatedGIF
Animated gif
commit 7d11c9c13034eb9c63108214875b6852c363ee16
Author: Dave Plummer <dave@MacStudio.local>
Date: Wed Nov 29 14:14:32 2023 -0800
Animation speed
commit ff1587b0ece8cc8ef8a1ce9677bad4c1848f2ca0
Author: Marshall G. Gates <mggates@gmail.com>
Date: Wed Nov 29 07:56:01 2023 -0500
Addressed issues in Pull Request
- Cleaned up variable naming format. We really need a standard. I am open to anything.
- Used std::min and std::max to clarify the codes meaning
commit 12d00eb0c7f39ba914f396e6484fa826ee248b72
Merge: 7814a73a bc51da05
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Wed Nov 29 13:08:18 2023 +0100
Merge upstream/main into pr/davepl/550
commit bc51da050eb923998af3bc0c718be3ef41e53845
Merge: d98be155 ab6cd758
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Wed Nov 29 12:57:45 2023 +0100
Merge pull request #542 from revision29/ColorFillEffectTweak
Effect manager global color and palette fire tweaks
commit ab6cd758c0e386ab1935dbc43ffe5ec15ab1d1d5
Merge: ce109a81 d98be155
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Wed Nov 29 11:58:58 2023 +0100
Merge remote-tracking branch 'upstream/main' into pr/revision29/542
commit ce109a81ff0dd4c6d654a141d1f9ece288240104
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Wed Nov 29 11:58:25 2023 +0100
map() don't do floats
commit 96fdc40e9b60f782a4d6a593bce99b650a62dea6
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Wed Nov 29 11:30:40 2023 +0100
Improve global color based palette
commit 7814a73a9f18dfc198d2c7a165178e8dbb866d0e
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Wed Nov 29 10:34:47 2023 +0100
Make GIFIdentifier an enum class
commit 53d8f3c901c96078266f0ab5eeb47c36bef45da2
Merge: d2263903 d98be155
Author: Dave Plummer <dave@daveandnikki.com>
Date: Tue Nov 28 17:06:24 2023 -0800
Merge branch 'main' of github.com:PlummersSoftwareLLC/NightDriverStrip into AnimatedGIF
commit e9891e0dd7124e454e7f05c2abd4a73bb9a80f5f
Author: Marshall G. Gates <mggates@gmail.com>
Date: Tue Nov 28 10:28:54 2023 -0500
Clean up debug logging
- Correct debug level
- Remove redunant logging
commit 2d75c26b923bc667969a6e17de0c41e171861769
Author: Marshall G. Gates <mggates@gmail.com>
Date: Tue Nov 28 10:16:38 2023 -0500
Properly include the std::chrono namespaces
- better time constant expressions
- Remove unneeded namespace prefixes
commit 5a8a5832e6bbd25cea3a29b47fd1c6e7796b290d
Author: Robert Lipe <robertlipe@gmail.com>
Date: Tue Nov 28 02:02:40 2023 -0600
Centralize port numbers in source
Instead of scattering port numbers in source, headers, or macros, we
stuff them into one grep-able enum.
Tested:
Touch test on (out-of-tree) Demo project with webserver, debugger turned on.
Successful buddybuild
Not tested:
Commodore pet rock. (Wat!?!)
commit d22639030f8af7ca71ce50b9181dbea203f30cf7
Author: Dave Plummer <dave@MacStudio.local>
Date: Mon Nov 27 18:28:33 2023 -0800
Add transparent GIF support and banana
commit 9d24a1c484eb1b629bb818cd6f60964b8d03f9ee
Merge: d98be155 6cbf1185
Author: Marshall G. Gates <mggates@gmail.com>
Date: Mon Nov 27 16:00:39 2023 -0500
Merge branch 'dev/mgg-weather-fix-tomorrow' into feature/Weather-Fix-Tomorrow-Temps
commit d98be155806bf046c74724ac512000f1a38754eb
Merge: e64cc858 41084206
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Mon Nov 27 20:13:16 2023 +0100
Merge pull request #546 from rbergen/fix-supernova
Fix vertical speed of new debris items in Supernova
commit 410842066d043139f26a22de39cd11ea7d35cad0
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Mon Nov 27 20:04:10 2023 +0100
Restore VU meter on Mesmerizer builds
commit 6cbf11857ac09eadad209361c249e2a1f9617581
Merge: da06746b e64cc858
Author: Marshall G. Gates <mggates@gmail.com>
Date: Mon Nov 27 13:54:35 2023 -0500
Merge remote-tracking branch 'upstream/main' into dev/mgg-weather-fix-tomorrow
commit 21f7c04fb497d813b1f8b460fc67bb490faed5d9
Merge: 21050755 e64cc858
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Mon Nov 27 13:55:07 2023 +0100
Merge remote-tracking branch 'upstream/main' into fix-supernova
commit 18164e17d4118af99b18b3d9f5fc2aafeb1b4c04
Merge: 90b2bc79 e64cc858
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Mon Nov 27 13:41:33 2023 +0100
Merge branch 'main' into ColorFillEffectTweak
commit e64cc85898a2827d94fc4a27ca6f2756bafdb585
Merge: 7ba9f57b 79f6f219
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Mon Nov 27 13:38:23 2023 +0100
Merge pull request #543 from davepl/AnimatedGIF
Animated gif support
commit 90b2bc79a7d4a4981fd92491010fdb5988dbb625
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Mon Nov 27 13:13:11 2023 +0100
SpectrumAnalyzerEffect uses global colors
commit 79f6f21905049775b95be134f347d13752976dc1
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Mon Nov 27 11:26:54 2023 +0100
Keep weather icons together
commit fd2501513880de8e06658e72688aaf2487a0792f
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Mon Nov 27 11:14:42 2023 +0100
Remove funny character
commit 21050755ebdde8523b612a077d5b33ece5bc5430
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Mon Nov 27 10:58:52 2023 +0100
Fix y speed of new paricles
commit 9c44086e5bd3b7e6a8d5d19f675d56cdaaca2635
Author: Dave Plummer <dave@MacStudio.local>
Date: Sun Nov 26 18:35:31 2023 -0800
Add threerings animation
commit a5ca09bb56b0bb35e4f27312a4f575c97ff56f41
Author: Dave Plummer <dave@MacStudio.local>
Date: Sun Nov 26 18:16:46 2023 -0800
Remove local data
commit 8c22f93c8f6e5b070ce1d7e93c8835c63c87fbf4
Merge: 0598957f 1bca9e52
Author: Dave Plummer <dave@MacStudio.local>
Date: Sun Nov 26 18:16:14 2023 -0800
Merge branch 'AnimatedGIF' of github.com:davepl/NightDriverStrip into AnimatedGIF
commit 0598957fdb6937940a73b178782ad9310828ab96
Author: Dave Plummer <dave@MacStudio.local>
Date: Sun Nov 26 18:16:08 2023 -0800
Update effects table for animated GIFs
commit da06746b76ca2c0ba3c6a39cda4c9402b2d9e3a0
Author: Marshall G. Gates <mggates@gmail.com>
Date: Sun Nov 26 12:32:13 2023 -0500
Reformat single statement ifs to match
Just getting it all to look the same inside the file
commit 3f75238100a3d16d043a52869f484013b2c41c13
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sun Nov 26 12:14:56 2023 +0100
Make line white spacing consistent
commit 1bca9e52259b44b823c855ddd681877b8e3439e3
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sun Nov 26 11:52:16 2023 +0100
Reorder embedded image assets
commit cd0d43eea4a92028b525bbbb6cbc97cdb0c57a3f
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sun Nov 26 11:50:08 2023 +0100
Fix variable declaration spacing
commit f49440135e1848adbffc95320402b44ca56d5b90
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sun Nov 26 11:02:42 2023 +0100
Fix MusicalPaletteFire
commit 177cb1e70ec9835727e29408678f7616db48d677
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sun Nov 26 10:43:29 2023 +0100
Revert spacing change, remove unnecessary variable
commit 15db9322f95fc99dd25fc34b34579e1837fcf0a3
Merge: 123fc058 ac1ed204
Author: Dave Plummer <dave@MacStudio.local>
Date: Sat Nov 25 19:39:41 2023 -0800
Merge branch 'AnimatedGIF' of github.com:davepl/NightDriverStrip into AnimatedGIF
commit 123fc05877767012faf5bd9295b35df39e2e75cc
Author: Dave Plummer <dave@MacStudio.local>
Date: Sat Nov 25 19:39:37 2023 -0800
Add arbitrary size support to animated GIF; pacman
commit 3bd6c12b308d68eb98850f76977286ac29b3d1ef
Author: Joe Schneider <joe@revision29.com>
Date: Sat Nov 25 20:40:32 2023 -0500
Tweak and a fix
- Removed redundant variable for PaletteFlameEffect child class.
- Changed the variable type `palette` in PaletteFlameEffect and MusicalPaletteFire. In effects.cpp, Dave had defined custom palettes in the effect constructor. Those were not reference to palette variables, so the code refused to compile. Though this is not the most memory efficient change, it allows the code to run.
commit 298e7289d14e8986260205de23a22c4f7211ee82
Author: Marshall G. Gates <mggates@gmail.com>
Date: Sat Nov 25 15:41:56 2023 -0500
Increase Allocated JSON Document size to capture all the forcast data
commit ac1ed2047a1abb4dd2a06c725041e74379cd5954
Author: David W Plummer <davepl@davepl.com>
Date: Sat Nov 25 07:26:18 2023 -0800
Update partitions_custom_8M.csv
commit b3ea832ef50d6097f275c86dc4e6a37a0a5de9c7
Merge: 9be33aa4 7ba9f57b
Author: David W Plummer <davepl@davepl.com>
Date: Sat Nov 25 07:24:44 2023 -0800
Merge branch 'PlummersSoftwareLLC:main' into AnimatedGIF
commit 7ba9f57b493b612cf42a10d3378f403a4087061a
Merge: 1a5e3505 4fcec83c
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sat Nov 25 09:43:29 2023 +0100
Merge pull request #532 from KeiranHines/feature/secondTiming
Interval input fixes
commit 967d87133f80a458cd56a3cd36fe21808b29263d
Author: Marshall G. Gates <mggates@gmail.com>
Date: Sat Nov 25 00:01:36 2023 -0500
Update getTomorrowTemps
- Use the std::chrono library for time related data
- Actually scan all the forcast blocks for tomorrow
- Get the noon weather icon for tomorrow
commit 9be33aa41668ac37552b2be9623756398426b8d3
Merge: 903d02bf 1a5e3505
Author: Dave Plummer <dave@MacStudio.local>
Date: Fri Nov 24 18:15:05 2023 -0800
Merge branch 'AnimatedGIF' of github.com:davepl/NightDriverStrip into AnimatedGIF
commit 903d02bf703a365010682fc3ebc93638cfdf183a
Author: Dave Plummer <dave@MacStudio.local>
Date: Fri Nov 24 18:13:46 2023 -0800
Tidy up
commit 759f8bc78dfa0a3ae04406223a0320531eda629a
Merge: 9c0db8fd 3dea3095
Author: Joe Schneider <joe@revision29.com>
Date: Fri Nov 24 19:53:37 2023 -0500
Merge branch 'ColorFillEffectTweak' of https://github.com/revision29/NightDriverStrip into ColorFillEffectTweak
commit 9c0db8fd3d290b1706e01a77845a84bbbd8615e9
Author: Joe Schneider <joe@revision29.com>
Date: Fri Nov 24 19:53:27 2023 -0500
Minor changes
Based on feedback and brief moments of sanity:
- Introduced PTY_IGNOREGLOBALCOLOR definition.
- Updated some indentation.
- Removed effectManager.Update() calls.
- Changed to simpler if then format in some places to save blinkenbits.
commit f0d68c34c38b259426affa00759561f2fa8ff892
Author: Dave Plummer <dave@MacStudio.local>
Date: Fri Nov 24 16:10:02 2023 -0800
Animated GIF Support
commit 4fcec83cdfd928b64577d9ff2048005088fabf68
Merge: 61fcb3ea f13c2a68
Author: keiranhines <keiranhines@gmail.com>
Date: Sat Nov 25 09:13:26 2023 +1100
Merge branch 'feature/secondTiming' of github.com:KeiranHines/NightDriverStrip into feature/secondTiming
commit 61fcb3ea27694d23e8d9706e2e6f637171481474
Author: keiranhines <keiranhines@gmail.com>
Date: Sat Nov 25 09:13:13 2023 +1100
Updated next effect handling by resyncing to trigger an update rather than trying to manage the next effect timing client side
commit f3e167aadc10ad6db109ddb738bab5dee8fa4f13
Author: keiranhines <keiranhines@gmail.com>
Date: Sat Nov 25 09:12:28 2023 +1100
Removed support for setting effect interval < 1s
commit ef17b52587b0f7875393163f2af9472f0cc7cb5c
Author: Marshall G. Gates <mggates@gmail.com>
Date: Fri Nov 24 16:56:00 2023 -0500
Convert refresh delay to use std::chrono
commit 6b76639156888c58c57e9263f3a4efc596a61157
Author: Marshall G. Gates <mggates@gmail.com>
Date: Fri Nov 24 16:54:16 2023 -0500
Unified Info and Warning debug message types
commit 3dea3095f5084119e64c6c3289d50a4bdf1012d4
Merge: db51032a 1a5e3505
Author: Joe Schneider <joe@revision29.com>
Date: Fri Nov 24 14:18:32 2023 -0500
Merge branch 'PlummersSoftwareLLC:main' into ColorFillEffectTweak
commit db51032a1eaaf3db023ff0140727480a472dff5f
Author: Joe Schneider <joe@revision29.com>
Date: Fri Nov 24 11:25:44 2023 -0500
Fixed variable order
Did not pay enough attention to the order arguments.
commit f725505fe851042a33feb48cb62169d5df212d33
Author: Joe Schneider <joe@revision29.com>
Date: Fri Nov 24 10:32:26 2023 -0500
Palette flame effect uses global color
Updated palette flame effect and musical palette flame effect to use global color
commit c7016b05e32675461301976db181511d67cd3864
Author: Joe Schneider <joe@revision29.com>
Date: Fri Nov 24 10:16:21 2023 -0500
Tweaking some effects
commit 1a5e35051dc465f2cf2c9e00229dfdcf56766a3c
Merge: 4ce357b4 0a8505ca
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Thu Nov 23 21:36:27 2023 +0100
Merge pull request #541 from revision29/ColorFillEffectTweak
Tweaked ColorFillEffect to optionally ignore global color
commit 0a8505cae167b9f80827d2dbcae7c6f0f99e3028
Author: Joe Schneider <joe@revision29.com>
Date: Thu Nov 23 14:56:44 2023 -0500
One last small change
Used short version of boolean check for both conditions.
commit 2a91710394af17e5f14e39750410d036dfd63fa5
Author: Joe Schneider <joe@revision29.com>
Date: Thu Nov 23 14:48:04 2023 -0500
Fixed childish errors
commit 4ce357b4a546a255a24637831034f8f26f13564c
Merge: a32d64c2 7047984f
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Thu Nov 23 18:34:05 2023 +0100
Merge pull request #537 from mggates39/feature/Fresh_Weather_Icons
Just Better Weather Icons
commit 2490eab0d02e54ef544437c55fe32901fb3f7d64
Author: Joe Schneider <joe@revision29.com>
Date: Thu Nov 23 11:32:29 2023 -0500
Tweaked ColorFillEffect to optionally ignore global color
Tweaked ColorFillEffect to optionally ignore global color
commit 7047984f42e4f797329cb676aa3b5337f9d0746f
Author: Marshall G. Gates <mggates@gmail.com>
Date: Thu Nov 23 10:03:03 2023 -0500
Address issues from code review.
- Revert promotion of configuration variables to secrets
- Correct JSON to string coercion
commit a32d64c2dd0643ba5f6d4bd80459594bba55d5d3
Merge: 8a05a776 586d769f
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Tue Nov 21 23:33:31 2023 +0100
Merge pull request #536 from robertlipe/format
Allow checking of format arguments against arguments in str_sprintf.
commit 586d769f1ecdb64d205447ea0257a4e2651679f0
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Tue Nov 21 23:01:56 2023 +0100
Update include/globals.h
commit 4f3e345717efb14fddef82eaa2ab5f434a06c70e
Author: Marshall G. Gates <mggates@gmail.com>
Date: Tue Nov 21 15:16:44 2023 -0500
Update to show proper day and night icons
- Added the new night icons to the list
- Changed icon map to use a String key
- Modify the icon retrieval to use the whole Icon ID string
- Fixed the logging to show the correct icon ID
commit 08a55099862f2e7e8c7843ae7d6634ae9b15496a
Author: Marshall G. Gates <mggates@gmail.com>
Date: Tue Nov 21 14:46:28 2023 -0500
Add the new night icons to the embedded files list
commit c23d905e99259d8926400aa7ee8bdf7e90819829
Author: Marshall G. Gates <mggates@gmail.com>
Date: Tue Nov 21 14:42:16 2023 -0500
Add the last two Weather confuration item defaults to the secrets.h file
## This is required for a recompile after this commit is applied
commit 60b76701a54a5cf044e3349e6eff775e6c1da284
Author: Marshall G. Gates <mggates@gmail.com>
Date: Tue Nov 21 14:12:51 2023 -0500
Update the device configuration
It needs to use the is location a zip code flag from the secrets file for the defalut value
commit 7817afc2c0c8683751cd71bc8d29bb665db09f83
Author: Marshall G. Gates <mggates@gmail.com>
Date: Tue Nov 21 13:48:39 2023 -0500
Replace the weather icons with new graphics
Clean up all of the unused old files
commit 30c2df99703a8174cb6413395ad87d7c0b42b92d
Author: Robert Lipe <robertlipe@gmail.com>
Date: Tue Nov 21 05:41:01 2023 -0600
Allow checking of format arguments against arguments in str_sprintf.
This detects the internal loop we previousluy fell into if we tried to
str_format("%s", String()); The test on vsnprintf() presumably couldn't
save us because our arg list had decayed to a va_list
It's bracketed to only come on if GCC, but clang is so dclose to us
it'll work there, too. Provide safe fallback for other code scanners, though.
Bonus: I've identified othr optimizations in here I can do when it's not
this time of day.
commit f13c2a682ff4751b6fd1f08ef4ed54b05cdda3d6
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Mon Nov 20 12:40:05 2023 +0100
Ignore intervals < 1s
commit 348aa0f99b3c8b20b89a025a1127982fe09bdc87
Author: keiranhines <keiranhines@gmail.com>
Date: Mon Nov 20 22:00:57 2023 +1100
Added support for configuring interval < 1s if you really want
commit 321529ca8406a6d50aca2db8cf5b001e4821856d
Author: keiranhines <keiranhines@gmail.com>
Date: Mon Nov 20 21:54:32 2023 +1100
Various fixes to interval input, added support for enter to submit, changed display from ms to a time format
commit 8a05a7766075ace3c8ab7f3ee0d71ad1a79e5289
Merge: 0b312403 4d66b3b2
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sun Nov 19 13:20:13 2023 +0100
Merge pull request #528 from rbergen/set-x-bit
Set executable bit on tools/show_features.py
commit 4d66b3b2a7a3004d86d8c9cc7a69bb7cf3e00d23
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sun Nov 19 12:59:57 2023 +0100
Set executable bit on new script
commit 0b312403c043a4e413b1dc5c52bcec4cfb2a1a82
Merge: 92fc2664 f8ba015b
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sun Nov 19 11:15:22 2023 +0100
Merge pull request #527 from rbergen/improve-web-installer
Make web installer report enabled features
commit f8ba015bc93c36ba47597fe4eb898d145c295867
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sun Nov 19 09:52:11 2023 +0100
Exclude feature letters from manifests
commit 1e01bf4f5c8e7dee816c53edb0df147cfa12f273
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sun Nov 19 08:54:46 2023 +0100
Fix copy/paste error
commit 9b911a61d679e7067232bdf063f4a619c44882ff
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sun Nov 19 00:04:26 2023 +0100
Decrease legent font size
commit 1896163d3e84771539abf58295f0d19dae4e874e
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sat Nov 18 21:42:52 2023 +0100
Change legend format
commit 96ad86c4b25351ef33d62c8cd6c5ede0cc767d77
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sat Nov 18 20:19:42 2023 +0100
Update main README
commit c7f90edd5182da8cffbbfd4d370b88651808ad4d
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sat Nov 18 20:13:47 2023 +0100
Change location of feature legend
commit f35f1419978317efcb02a10dc04aed704820a0d0
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sat Nov 18 19:40:00 2023 +0100
Restore full web_projects.json
commit 4cdb52b1dfa78c42c17f2b7c681c5725f6b40f2c
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sat Nov 18 19:33:16 2023 +0100
Make handling of feature flags more clever
commit 92fc26642e8934f270bdc34cfff50cf9031c70c0
Merge: 0884d6f9 4092cca8
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sat Nov 18 09:58:06 2023 +0100
Merge pull request #525 from rbergen/update-smsmoke
Remove tear/pepper in fire from SMSmoke
commit 4092cca8624b3e7e4357a216a8e1de4627a25f14
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sat Nov 18 03:57:27 2023 +0100
Remove tear/pepper in fire
commit 0884d6f924e909edf7a8c5c1b189df3390165ee9
Merge: 32779b6c 8b3af692
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sat Nov 18 03:50:39 2023 +0100
Merge pull request #524 from rbergen/add-vu-setting
Add persisted "show VU" setting to web UI
commit 32779b6ca557d53d63837498998d7535dcde8ba3
Merge: abe99df6 c7616d8a
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sat Nov 18 03:50:17 2023 +0100
Merge pull request #518 from KeiranHines/feature/deviceControl
Feature/device control
commit c7616d8a7edc260add886c127bf455a68091e5b8
Author: Keiran Hines <keiranhines@gmail.com>
Date: Sat Nov 18 09:40:17 2023 +1100
Addressed PR feedback. Moved popover to a parent anchor point to sit better on the sidebar
commit 8b3af69278ecb5a153bb7b3de61e4ed41f0a6bb2
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Fri Nov 17 18:09:14 2023 +0100
Polish implementation, specs and comments
commit 0cb7b5cfaac34fa95c7578e29cc89df9cd753bef
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Fri Nov 17 17:49:54 2023 +0100
Hook up show VU meter setting to logic
commit 4f9b9126c42f760a132540ed61189468577f7ad9
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Fri Nov 17 17:04:03 2023 +0100
Add Show VU meter setting
commit abe99df68f9a5be852338637705c6344fe1f3150
Merge: 135735f3 1d7edab8
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Fri Nov 17 13:02:45 2023 +0100
Merge pull request #521 from robertlipe/sm_scrub
Force-initialize class members to zero in SM effects.
commit 135735f32d91130769494fe4ce185f904e4f76b1
Merge: 11851a08 da7f81c1
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Fri Nov 17 12:26:54 2023 +0100
Merge pull request #522 from robertlipe/blur_fix
As taunted, major C++-ification of BlurringColors/Powder
commit da7f81c140d72364dd9472637a903ae0d85f9eb0
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Fri Nov 17 11:05:18 2023 +0100
Clear PowderItems on every Start()
commit 4ec848725b03f0c4b97bc90b859c70749c41aa81
Merge: 032a9e94 11851a08
Author: Robert Lipe <robertlipe@users.noreply.github.com>
Date: Thu Nov 16 23:50:25 2023 -0600
Merge branch 'main' into blur_fix
commit 032a9e943b053fa2ba47a7fc8376fbf56d6c0a10
Author: Robert Lipe <robertlipe@gmail.com>
Date: Thu Nov 16 23:33:10 2023 -0600
As taunted, major C++-ification of BlurringColors/Powder
This file's version of https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/489
Ran on Mesmerizer for 30+ minutes. Did not measure before/after frame
rates but it should help that it's using more indexed addressing modes
( mov t0, 1234($t1) ) instead of recomputing index offset addresses
(lea ...) so many times per method. A loop next now is the addition of the
size of the structure we're iterating over.
Tried to pull in the changes that happend in https://github.com/PlummersSoftwareLLC/NightDriverStrip/pull/512
commit 1d7edab80e812e26fbc6349caa3b31601e3dbfd4
Author: Robert Lipe <robertlipe@gmail.com>
Date: Thu Nov 16 19:31:40 2023 -0600
Force initialization of anything in the SM patterns to zero.
This is admittedly a mechanical processing of any class-local
variable I couldn't trivially prove to be initialized before use.
Trivial touch-ups in adjacent code if I was sure they were low risk.
commit 11851a08649ce1b1af2c060fafa48deda828acb8
Merge: d18cb4a4 f0a3e6b2
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Thu Nov 16 21:26:53 2023 +0100
Merge pull request #519 from rbergen/fix-powder-effect
Fix Powder/PatternSMBlurringColors effect
commit f0a3e6b211ec263437a82863deca52a540e19021
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Thu Nov 16 21:05:26 2023 +0100
Fix Powder/SMBlurringColors effect
commit d18cb4a4593cda26f9fcdfdca0297176c1ff0ec7
Merge: d82e528f bf1d569d
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Thu Nov 16 11:34:28 2023 +0100
Merge pull request #517 from KeiranHines/bugFix/configDialog
Bug fix/config dialog
commit d82e528f4be268979cd1da27592ad06a85e4302a
Merge: 3b796e5c 919ec2d5
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Thu Nov 16 11:33:04 2023 +0100
Merge pull request #516 from robertlipe/fastled
Fix crash on "large" configurations, especially on ESP32-S3.
commit b12be9277e702c353c8735ef880c9b0352a9bfe4
Author: keiranhines <keiranhines@gmail.com>
Date: Thu Nov 16 21:23:26 2023 +1100
Fixed issue #482: Added a power settings button to the sidebar reboot and reset options.
commit bf1d569d54f67d888f30856c23b1ca0acab81d6a
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Thu Nov 16 11:20:59 2023 +0100
Make some setting descriptions less techie
commit 67fa187dcc40b85aea47990372740fee060d94e6
Author: keiranhines <keiranhines@gmail.com>
Date: Thu Nov 16 21:13:25 2023 +1100
Addressed PR feedback again
commit b3c37dc54cf55f253fd7bad28269e29811317ba1
Author: keiranhines <keiranhines@gmail.com>
Date: Thu Nov 16 21:09:27 2023 +1100
added popover
commit b42f4ff5da00f96757bb7d0ae83f2af6d5837e52
Author: keiranhines <keiranhines@gmail.com>
Date: Thu Nov 16 20:51:21 2023 +1100
Addressed PR feedback
commit f663823f75e027e2539e86d46f11859046e5e4bc
Author: keiranhines <keiranhines@gmail.com>
Date: Thu Nov 16 20:49:01 2023 +1100
Added settings_power button for power menu
commit b6097d9b04ffc10ce181c30045001cc3b935bbec
Author: keiranhines <keiranhines@gmail.com>
Date: Thu Nov 16 20:22:16 2023 +1100
Fixed sylying of color and slider inputs
commit e58980dbc45c6e178210a99b6101fb42449d6448
Author: keiranhines <keiranhines@gmail.com>
Date: Thu Nov 16 20:19:56 2023 +1100
Fixed #504 added descriptions to checkboxes, restyled some inputs and added some padding before input title
commit 919ec2d5794029ab1db22e712e612c011c154a33
Author: Robert Lipe <robertlipe@gmail.com>
Date: Wed Nov 15 14:53:02 2023 -0600
Fix crash on "large" configurations, especially on ESP32-S3.
See https://github.com/PlummersSoftwareLLC/NightDriverStrip/issues/515
for the (painful) details.
commit 3b796e5cdfe16d55fef306c7e998228ed9b174d6
Merge: 916c083e 071f85a4
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Wed Nov 15 21:00:57 2023 +0100
Merge pull request #503 from rbergen/global-color-settings
Add global color settings
commit 916c083e476fa0144be2cf68cadf7755a550ffb4
Merge: a7a34ebf 1a4b7bdd
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Wed Nov 15 01:29:40 2023 +0100
Merge pull request #509 from davepl/main
Add effect comments, update star and amber rain effects
commit a7a34ebf434da506285c31f0c3878f9addfeafae
Merge: a300bb68 46485d99
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Wed Nov 15 01:28:55 2023 +0100
Merge pull request #499 from revision29/serializerfailwell
Update jsonserializer.cpp to break infinite fail
commit 071f85a44ffbb36663cddb27e2ddb0fa10b46033
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Tue Nov 14 22:43:38 2023 +0100
Clean up
commit a19d63d0d5078963aed3b718e04520360203c7b1
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Tue Nov 14 21:20:20 2023 +0100
Persist application of global colors
commit a300bb688b9ad39298330e5f4c687330ba1770c1
Merge: cc99495f 1f81ee83
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Tue Nov 14 20:12:24 2023 +0100
Merge pull request #512 from rbergen/fix-510
Fix Supernova effect
commit 1f81ee83c1f05055d7aa205b6f656c744d9b3744
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Tue Nov 14 19:56:14 2023 +0100
Esthetics
commit a49dc0d7cccc32fa753593a41baf7195ecd3d28a
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Tue Nov 14 19:52:42 2023 +0100
Review comments
commit ff5f2fa538a67aff5b863aa75c951ac06b84cea6
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Tue Nov 14 17:59:05 2023 +0100
...but we are for_each-ing
commit cc99495f9df46c8b1b185d9477825ba26d1cee85
Merge: 0304fa1a fc329a9b
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Tue Nov 14 16:38:43 2023 +0100
Merge pull request #511 from KeiranHines/feature/designerImprovements
Feature/designer improvements
commit 5583b16b890f2eae309a7b47ff43c39c1e5d5d2d
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Tue Nov 14 14:18:58 2023 +0100
We're not actually transforming
commit 11b367d8c300472ae2d1cd6422726b5d9a2fc877
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Tue Nov 14 14:15:09 2023 +0100
Satisfy capitalization OCD
commit 65882cc18c30b7b8800a4b295ab1c01991c4d551
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Tue Nov 14 14:12:39 2023 +0100
Don't assume SHOW_VU_METER is defined
commit b683d0f59fab73872bff40d6609b778c0d5edf0c
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Tue Nov 14 13:48:31 2023 +0100
Fix issue 510
commit fc329a9bd6bdff8fb68cce66990cf3f4c6a99242
Merge: bd300ac7 0304fa1a
Author: keiranhines <keiranhines@gmail.com>
Date: Tue Nov 14 21:27:06 2023 +1100
Merge branch 'main' of https://github.com/PlummersSoftwareLLC/NightDriverStrip into feature/designerImprovements
commit 38edb06b141aa22b591944b22ca969ccd31f459d
Author: keiranhines <keiranhines@gmail.com>
Date: Tue Nov 14 21:25:53 2023 +1100
Initial Design of #504
commit 1a4b7bdd51a21900de44295e161e2be704ce7d7c
Merge: 02f1febe 0304fa1a
Author: David W Plummer <davepl@davepl.com>
Date: Mon Nov 13 16:40:34 2023 -0800
Merge branch 'PlummersSoftwareLLC:main' into main
commit 02f1febe006a360ab07930b034211b463e762e6d
Author: Dave Plummer <dave@MacStudio.local>
Date: Mon Nov 13 11:23:49 2023 -0800
Comment files, fix amber rain
commit 46485d9961282c64df74d2159d698eaf8affb154
Merge: 4702f196 0304fa1a
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Mon Nov 13 15:19:35 2023 +0100
Merge 'upstream/main' into pr/revision29/499
commit e018beafd6aef0dcde52cd9d88d4e7ba1b2f2f43
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Mon Nov 13 15:15:47 2023 +0100
Extend and refactor color setting logic
commit 3c86c7b99c9fd7ddd3eaa09891dbf521af09e6bd
Merge: 9d52bfe1 0304fa1a
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Mon Nov 13 11:44:41 2023 +0100
Merge remote-tracking branch 'upstream/main' into global-color-settings
commit 0304fa1a8dc94426b3e6f76c7e7fbf8e1de60741
Merge: 83714e30 8df90144
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Mon Nov 13 11:38:20 2023 +0100
Merge pull request #494 from KeiranHines/feature/configDialog
Feature/config dialog
commit 83714e30e3c12b21a08b0a0416104557c04b30e7
Merge: b3f87bab e1839162
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Mon Nov 13 11:18:35 2023 +0100
Merge pull request #501 from rbergen/reconfigure-spectrum
Reconfigure Spectrum builds
commit 4702f1962c84969d4049b5f9266ae214845e6cb4
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Mon Nov 13 10:09:35 2023 +0100
Review updates
commit 8df90144732e4191412a2b125d5341c8538eb139
Author: keiranhines <keiranhines@gmail.com>
Date: Mon Nov 13 18:49:06 2023 +1100
Fixed issue where error update on an empty string would check previous value not current value
commit f809e1ce1b73e1a7fbbec6afe4c66d77f74ffc44
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sun Nov 12 14:32:56 2023 +0100
Handle JSON serialization failures
commit 48254063af2d3dfad212bb6fa1f92e1484271bc4
Author: keiranhines <keiranhines@gmail.com>
Date: Sun Nov 12 21:40:54 2023 +1100
removed if statement used for testing palette mode
commit 9ac1993177fb02eaa510adc28340582c15a5f45b
Author: Joe Schneider <joe@revision29.com>
Date: Sat Nov 11 12:24:07 2023 -0500
Update jsonserializer.cpp to break infinite fail
Added code to catch instances where SerializeWithBufferSize gets into an *infinite fail loop. Adjusted SaveToJSONFile to handle SerializeWithBufferSize failing.
commit e18391620cbfb0af0d61725880c9c671f3a74fc5
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sat Nov 11 10:38:44 2023 +0100
One more
commit edabdc116b4c32c98a80fb1070f9b7d50e0bfc49
Merge: fcb70133 202dd4af
Author: keiranhines <keiranhines@gmail.com>
Date: Sat Nov 11 07:33:20 2023 +1100
Merge branch 'feature/configDialog' of github.com:KeiranHines/NightDriverStrip into feature/configDialog
commit 922ab31695775a50a0d6dba89b367df8a822b1c6
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Fri Nov 10 12:36:26 2023 +0100
Turn off more services
commit adba3d2bcc70773bee5a0cb3e35d45888aed7e6f
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Fri Nov 10 09:57:46 2023 +0100
Disable services
commit 9d52bfe117fd90e336c181ff37450119aee9dc13
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Fri Nov 10 08:51:46 2023 +0100
Make global colors device settings
commit fcb70133d524b374b9871bb69112fa90e858fd0a
Author: keiranhines <keiranhines@gmail.com>
Date: Thu Nov 9 19:07:49 2023 +1100
Fixed issue with inconsistent behaviour of reset and cancel when changing colors multiple times
commit 202dd4af508e29b49938832ed82da2550651feec
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Wed Nov 8 13:17:34 2023 +0100
Make brightness a Slider setting
commit bd300ac743f39ae9f612d6125257dc737433619d
Author: keiranhines <keiranhines@gmail.com>
Date: Wed Nov 8 23:03:40 2023 +1100
removed dead code
commit f6c7184e2898e937e09cef3c6a9664dc1fb51301
Author: keiranhines <keiranhines@gmail.com>
Date: Wed Nov 8 23:00:59 2023 +1100
Fixed issues with dialog rendering early and added RGB numeric inputs to the color picker dialog
commit d804b148b779ad6fa452e1ee6b2377913a2d1158
Author: keiranhines <keiranhines@gmail.com>
Date: Wed Nov 8 21:11:31 2023 +1100
Changed circularProgress to LinearProgress
commit af6166e4001aad92185e232718f5027db7638926
Merge: d0d752a7 b3f87bab
Author: keiranhines <keiranhines@gmail.com>
Date: Tue Nov 7 09:12:59 2023 +1100
Merge branch 'main' of https://github.com/PlummersSoftwareLLC/NightDriverStrip into feature/designerImprovements
commit 64c37780a284fa0a30f3a3aa4e35a148be37086a
Author: keiranhines <keiranhines@gmail.com>
Date: Tue Nov 7 09:10:46 2023 +1100
Changed check for emptyAllowed === false to be more readable
commit cdbd64190e76001db7861687b30d2f8a67ab6750
Author: keiranhines <keiranhines@gmail.com>
Date: Mon Nov 6 23:45:49 2023 +1100
Code cleanup of debug messages
commit 3f8f9c85ea1ffd71f64126e4e157e4dbddf9de31
Author: keiranhines <keiranhines@gmail.com>
Date: Mon Nov 6 23:43:06 2023 +1100
Added support for Slider Type
commit 91dcf8c542090b92ec973f21d9fc47829df4906a
Author: keiranhines <keiranhines@gmail.com>
Date: Mon Nov 6 23:35:35 2023 +1100
Fix #493 point 3: Added support for a palette configuration in the config dialog
commit 42847e394ccc74525fae1145931bb551a268044e
Author: keiranhines <keiranhines@gmail.com>
Date: Mon Nov 6 22:43:37 2023 +1100
Fix #493 point 2: Added support for a color picker and implemented the Color Type in the config dialog.
Added Support for selection colors in PatternSubscribers as a test case
commit 437e0a2723dcc3f242ef54c23469854ae6d0cd61
Author: keiranhines <keiranhines@gmail.com>
Date: Mon Nov 6 20:45:22 2023 +1100
Initial work on setting up a test for setting color
commit 7bb75170c531af09573d1ebf831a613b784da2a1
Author: keiranhines <keiranhines@gmail.com>
Date: Mon Nov 6 18:39:18 2023 +1100
Fixed #491 point 1: emptyAllowed now handled for strings with an error message. For all other types if emptyAllowed is set and no error is raised the original value will be sent as a fallback
commit b3f87babc4402e0125c70fdeacd506cdb3991568
Merge: 46dca0aa a0c4c3b6
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Mon Nov 6 08:09:05 2023 +0100
Merge pull request #478 from KeiranHines/optionalSettings
Config dialog improvements
commit 564197f7a30e89ff73079366232f040357d191e0
Merge: 5c61b231 46dca0aa
Author: David W Plummer <davepl@davepl.com>
Date: Sun Nov 5 13:17:36 2023 -0800
Merge branch 'PlummersSoftwareLLC:main' into main
commit 46dca0aafe12671553bcae9eb893b057c5a9b2d3
Merge: 070b5a37 68a91a26
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sun Nov 5 13:33:26 2023 +0100
Merge pull request #492 from rbergen/fix-subs-settings-bug
Fix Subscribers effect settings serialization bug
commit 68a91a26b2b81b9ba2eade91ef48b1a268ab7de6
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sun Nov 5 13:09:47 2023 +0100
Fix settings serialization bug
commit 070b5a37e6f1dba494a28e15c283330599da1248
Merge: 67fafbf7 2e091e30
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sun Nov 5 12:56:31 2023 +0100
Merge pull request #490 from rbergen/settingspec-updates
Extend SettingSpec
commit 2e091e305810c5ce81f3ec20c739d2ff659c468e
Merge: a00abc4a 67fafbf7
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sun Nov 5 12:40:22 2023 +0100
Merge remote-tracking branch 'upstream/main' into pr/rbergen/490
commit a00abc4a855a6c9a02b5e7de544bbce127cf4acb
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sun Nov 5 12:39:54 2023 +0100
Return actual effect interval
commit 67fafbf757aa44c54da5543e763cb3adf01b8bcb
Merge: 9ac393c4 67f30766
Author: Rutger van Bergen <rbergen@xs4all.nl>
Date: Sun Nov 5 12:37:31 2023 +0100
Merge pull request #477 from KeiranHines/feature/globalEffectState
Feature/global effect state
commit d0d752a797099cccfd4a84a140995cb43cb76d9f
Author: keiranhines <keiranhines@gmail.com>
Date: Sun Nov 5 14:40:56 2023 +1100
fixed wrong propType on effect Card
commit fba4481f1acb27e0eaadd736db6f12c48b512cb7
Author: keiranhines <keiranhines@gmail.com>
Date: Sun Nov 5 13:15:21 2023 +1100
Added time remaining and some color to the circular progess in list view
commit 586cbf2adfd2cb87eb010b717390650f5c62aafa
Author: keiranhines <keiranhines@gmail.com>
Date: Sun Nov 5 11:59:25 2023 +1100
minor fix to progress circle position
commit 1ad8310e49675fd211d92b3585c139fba7d0bd8a
Author: keiranhines <keiranhines@gmail.com>
Date: Sun Nov 5 11:41:53 2023 +1100
Updated list view to include settings cog and various styling changes to support varied screen size
commit 5c61b23186045e8d791fa5c68c56e2b9be9e4d7d
Author: Dave Plummer <dave@MacStudio.local>
Date: Sat Nov 4 14:36:45 2023 -0700
Merge branch 'main' of github.com:davepl/NightDriverStrip
commit 0ec84fcb5b4e8c6dcae8c85b1819ef0cdf1db358
Merge: 345b9ac4 2a7af1fc
Author: Dave Plummer <dave@MacStudio.local>
Date: Sat Nov 4 14:35:52 2023 -0700
Merge branch 'main' of github.com:davepl/NightDriverStrip
commit 345b9ac46883521c84df686f0698f0ec45a6d967
Author: Dave Plummer <dave@MacStudio.local>
Date: Sat Nov 4 14:35:48 2023 -0700
Make clock pretty, star deep colors
commit 14c4f241ef94be8ecdb77ef71c3989bfb7c699dc
Merge: 8522cf42 67f30766
Author: keiranhines <keiranhines@gmail.com>
Date: Sun Nov 5 08:23:27 2023 +1100
Merge branch 'feature/globalEffectState' of github.com:KeiranHines/NightDriverStrip into feature/designerImprovements
commit 67f307665b0773b51db90a4ba08daa9b5a099a3f
Author: keiranhines <keiranhines@gmail.com>
Date: Sun Nov 5 08:23:01 2023 +1100
Fixed incorrect time being used to calculate progress animation
commit 8522cf428f33df2c2175c02fe0e9b9b4867e30e5
Author: keiranhines …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes #583 by not lazily relying on an unsigned underflow when preparing
_iCurrentEffectfor the first "proper" effect after the splash logo.Contributing requirements
mainas the target branch.