Make Stock effect compare against previous day's close #670
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This closes #662 by making the effect compare against the previous day's close instead of today's open. It does this both in the numeric change shown, as in the graph underneath it.
There is still one "peculiarity" that people may notice, which is that the data points in the graph include after-hour trading, and we don't show this in the coloring of the graph (Google and other sources tend to show after-hour trading in a different color).
This means that the last data point for a calendar day may be positive (green) while the (correct) day change is negative, or vice versa. If we want to change this then we need the stockserver to indicate in its response to the effect what data points are outside of regular trading hours.
Also, the default host for the stockserver changed from davepl.com to davepl.dyndns.org, to better handle IP address changes for Dave's Internet connection.
Contributing requirements
main
as the target branch.