Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transaction witness set 'attach' functions #1653

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Fix transaction witness set 'attach' functions #1653

merged 2 commits into from
Sep 26, 2024

Conversation

errfrom
Copy link
Collaborator

@errfrom errfrom commented Sep 26, 2024 •
edited
Loading

Pre-review checklist

  • All code has been formatted using our config (make format)
  • Any new API features or modification of existing behavior are covered with tests
  • The template (templates/ctl-scaffold) has been updated
  • The changelog has been updated under the ## Unreleased header, using the appropriate sub-headings (### Added, ### Changed, ### Removed, ### Fixed), and the links to the appropriate issues/PRs have been included

@errfrom errfrom self-assigned this Sep 26, 2024
@errfrom errfrom marked this pull request as ready for review September 26, 2024 15:56
marcusbfs
marcusbfs approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@marcusbfs marcusbfs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@errfrom errfrom merged commit 391dda3 into develop Sep 26, 2024
3 checks passed
@errfrom errfrom deleted the dshuiski/tx-witness-set branch September 26, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcusbfs marcusbfs marcusbfs approved these changes

Assignees

@errfrom errfrom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@errfrom @marcusbfs