프리뷰 제외 추가

Pluu · Jul 31, 2024 · fca9a63 · fca9a63
1 parent ddd802c
commit fca9a63
Show file tree

Hide file tree

Showing 7 changed files with 58 additions and 0 deletions.
diff --git a/app/build.gradle b/app/build.gradle
@@ -62,5 +62,6 @@ dependencies {
 
     implementation(platform(libs.androidX.compose.bom))
     implementation(libs.bundles.androidX.compose)
+    debugImplementation(platform(libs.androidX.compose.bom))
     debugImplementation(libs.bundles.androidX.compose.debug)
 }
diff --git a/app/src/main/java/com/pluu/lintstudy/compose/modifier_parameter.kt b/app/src/main/java/com/pluu/lintstudy/compose/modifier_parameter.kt
@@ -3,6 +3,7 @@ package com.pluu.lintstudy.compose
 import androidx.compose.foundation.text.BasicText
 import androidx.compose.runtime.Composable
 import androidx.compose.ui.Modifier
+import androidx.compose.ui.tooling.preview.Preview
 
 @Composable
 fun SampleSuccess(text: String, modifier: Modifier) {
@@ -17,4 +18,10 @@ fun SampleFailure(text: String) {
 @Composable
 private fun Sample3(text: String) {
     BasicText(text = text)
+}
+
+@Preview
+@Composable
+fun SampleFailure4() {
+
 }
diff --git a/lint/src/main/java/androidx/compose/lint/ComposableUtils.kt b/lint/src/main/java/androidx/compose/lint/ComposableUtils.kt
@@ -101,6 +101,9 @@ fun UExpression.isInvokedWithinComposable(): Boolean {
 val PsiMethod.isComposable
     get() = annotations.any { it.qualifiedName == Names.Runtime.Composable.javaFqn }
 
+val PsiMethod.isComposablePreview
+    get() = annotations.any { it.qualifiedName == Names.ToolingPreview.Preview.javaFqn }
+
 /** Returns whether this variable's type is @Composable or not */
 val UVariable.isComposable: Boolean
     get() {

diff --git a/lint/src/main/java/androidx/compose/lint/Names.kt b/lint/src/main/java/androidx/compose/lint/Names.kt
@@ -33,6 +33,10 @@ object Names {
         val PackageName = Package("androidx.compose.animation.core")
     }
 
+    object ToolingPreview {
+        val Preview = Name(Package("androidx.compose.ui.tooling.preview"), "Preview")
+    }
+
     object Runtime {
         val PackageName = Package("androidx.compose.runtime")
 

diff --git a/lint/src/main/java/com/pluu/lint/compose/RequiredModifierParameterDetector.kt b/lint/src/main/java/com/pluu/lint/compose/RequiredModifierParameterDetector.kt
@@ -3,6 +3,7 @@ package com.pluu.lint.compose
 import androidx.compose.lint.Names
 import androidx.compose.lint.inheritsFrom
 import androidx.compose.lint.isComposable
+import androidx.compose.lint.isComposablePreview
 import androidx.compose.lint.returnsUnit
 import com.android.tools.lint.client.api.UElementHandler
 import com.android.tools.lint.detector.api.Category
@@ -27,6 +28,8 @@ class RequiredModifierParameterDetector : Detector(), SourceCodeScanner {
             override fun visitMethod(node: UMethod) {
                 // Ignore non-composable functions
                 if (!node.isComposable) return
+                // Ignore composable preview functions
+                if (node.isComposablePreview) return
                 // Ignore non-unit composable functions
                 if (!node.returnsUnit) return
                 // Ignore private composable functions

diff --git a/lint/src/test/java/androidx/compose/lint/test/Compose.kt b/lint/src/test/java/androidx/compose/lint/test/Compose.kt
@@ -25,6 +25,21 @@ import org.intellij.lang.annotations.Language
 import java.util.Locale
 
 object ComposeStubs {
+    val Preview: TestFile =
+        kotlin(
+            """
+package androidx.compose.ui.tooling.preview
+
+@MustBeDocumented
+@Retention(AnnotationRetention.BINARY)
+@Target(
+    AnnotationTarget.ANNOTATION_CLASS,
+    AnnotationTarget.FUNCTION
+)
+@Repeatable
+annotation class Preview
+            """.trimIndent()
+        )
     val Composable: TestFile =
         bytecodeStub(
             filename = "Composable.kt",

diff --git a/lint/src/test/java/com/pluu/lint/RequiredModifierParameterDetectorTest.kt b/lint/src/test/java/com/pluu/lint/RequiredModifierParameterDetectorTest.kt
@@ -64,4 +64,29 @@ fun SampleSuccess(text: String) {
                 """.trimIndent()
             )
     }
+
+    @Test
+    fun testPreviewSuccess() {
+        lint()
+            .files(
+                kotlin(
+                    """
+package com.pluu.lintstudy.compose
+
+import androidx.compose.runtime.Composable
+import androidx.compose.ui.tooling.preview.Preview
+
+@Preview
+@Composable
+fun SampleSuccess() {
+}
+            """
+                ),
+                ComposeStubs.Composable,
+                ComposeStubs.Modifier,
+                ComposeStubs.Preview,
+            )
+            .run()
+            .expectClean()
+    }
 }