Fix standalone install and add debian 12 support #573
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juggler31
changed the title
juggler31
force-pushed
the
update_some_install_file
branch
from
2fc70e8 to
0f654cc
Compare
juggler31
force-pushed
the
update_some_install_file
branch
2 times, most recently
from
5bec328 to
779fd73
Compare
| @@ -36,7 +36,7 @@ geoalchemy2==0.9.4 | |||
| # via -r requirements.in | |||
| geojson==2.5.0 | |||
| # via -r requirements.in | |||
| greenlet==1.1.3 | |||
| greenlet==3.0.3 | |||
There was a problem hiding this comment.
- fixer la version de greenlet sera à faire dans
requirements.in, - pas pu tester sur Debian 11 pour le moment,
- cependant je ne vois pas d'utilisation de SQLAlchemy dans un mode asynchrone dans GN-Atlas, je ne pense pas que
greenletsoit utilisé, la dépendance est juste incluse par défaut, - ce serait intéressant d'avoir l'erreur rencontrée lors de l'installation sur Ubuntu 24.04 pour documenter le pourquoi de cette montée de version.
There was a problem hiding this comment.
Oui en effet.
Concernant greenlet voir aussi les discussions :
There was a problem hiding this comment.
Pour cela, j'ai rajouté un test dans les github actions pour tester l'installation des requirements.txt sur les différentes versions de python.
juggler31
force-pushed
the
update_some_install_file
branch
23 times, most recently
from
1701ed9 to
7a6cbe6
Compare
juggler31
requested review from
camillemonchicourt,
marcantoinedupre and
submarcos
submarcos
approved these changes
Oct 1, 2024
submarcos
reviewed
Oct 1, 2024
juggler31
changed the title
juggler31
force-pushed
the
update_some_install_file
branch
from
7a6cbe6 to
dd0e3e8
Compare
install_db.sh => work without geonature (geonature-atlas alone) install_env.sh => add wget + use python3 requirements.txt => update greenlet
juggler31
force-pushed
the
update_some_install_file
branch
from
dd0e3e8 to
0974436
Compare
| @@ -132,6 +132,10 @@ if ! database_exists $db_name | |||
| -v type_territoire=$type_territoire \ | |||
| -f data/gn2/atlas_ref_geo.sql &>> log/install_db.log | |||
| else | |||
|
|
|||
| echo "Create extension defined in geonature" | |||
| sudo -u postgres -s psql -d $db_name -c "CREATE EXTENSION IF NOT EXISTS unaccent;" &>> log/install_db.log | |||
There was a problem hiding this comment.
L'ajout de l'extension n'est pas au bon endroit, il faut l'ajouter pour tous au début du fichier, avec les autres extensions. On s'en charge.
amandine-sahl
changed the base branch from
develop
to
feat/fix_install_debian12
|
intégré dans #582 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cette PR corrige les installations sur un debian 12.