Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extension verify tests #949

Merged
merged 13 commits into from
Apr 29, 2024
Merged

Add extension verify tests #949

merged 13 commits into from
Apr 29, 2024

Conversation

nuel77
Copy link
Member

@nuel77 nuel77 commented Apr 27, 2024

Summary by CodeRabbit

  • New Features

    • Introduced dynamic user registration upon their first deposit to enhance user experience.
  • Refactor

    • Enhanced signature verification for withdrawal requests to support both proxy and main accounts, improving security and error handling.
  • Tests

    • Added new tests for signature verification in orders and withdrawal requests.

@nuel77 nuel77 added the A0-PleaseReview Pull request needs code review. label Apr 27, 2024
@nuel77 nuel77 self-assigned this Apr 27, 2024
Copy link
Contributor

coderabbitai bot commented Apr 27, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The recent updates streamline the asset management process in a blockchain environment, enhancing user registration and signature verification. The first set of changes automates user registration upon their initial deposit, improving the flow of asset transfers. The second update refines the verification process for withdrawal requests, ensuring both proxy and main accounts are properly authenticated, thus bolstering security and error management.

Changes

File Path Change Summary
pallets/ocex/.../lib.rs Introduced dynamic user registration on first deposit; removed static account existence check.
primitives/orderbook/.../types.rs Enhanced signature verification for proxy and main accounts in WithdrawalRequest; improved error handling and added relevant tests.

🐇💻🌟
Oh, hark! A change is here, my dear,
With code that dances, swift and clear.
First deposits weave a magic gate,
Signatures checked, secure their fate.
In blockchain's realm, we hop and strive,
With every line, our dreams alive.
🌟💻🐇


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@nuel77 nuel77 added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Apr 28, 2024
@nuel77
Copy link
Member Author

nuel77 commented Apr 28, 2024

@coderabbitai review

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

primitives/orderbook/src/types.rs Show resolved Hide resolved
@nuel77 nuel77 added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Apr 29, 2024
@pavankanteti pavankanteti requested a review from zktony April 29, 2024 07:38
Gauthamastro
Gauthamastro previously approved these changes Apr 29, 2024
@nuel77 nuel77 added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Apr 29, 2024
… add-extension-verify-tests

# Conflicts:
#	pallets/ocex/src/tests.rs
@Gauthamastro Gauthamastro added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Apr 29, 2024
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 73.68421% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 40.74%. Comparing base (d288202) to head (846fdf8).

Files Patch % Lines
primitives/orderbook/src/types.rs 70.58% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           Develop     #949      +/-   ##
===========================================
+ Coverage    39.87%   40.74%   +0.87%     
===========================================
  Files           67       67              
  Lines         5630     5632       +2     
===========================================
+ Hits          2245     2295      +50     
+ Misses        3385     3337      -48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zktony zktony added A0-PleaseReview Pull request needs code review. and removed A0-PleaseReview Pull request needs code review. labels Apr 29, 2024
@Gauthamastro Gauthamastro merged commit b89e840 into Develop Apr 29, 2024
3 checks passed
@Gauthamastro Gauthamastro deleted the add-extension-verify-tests branch April 29, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A0-PleaseReview Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants