Direct Deposit/Withdrawal

[Gauthamastro]

Describe your changes

1. Registers main account and deposits the assets on detection of direct deposit XCM type
2. Modified Ob Withdrawal to use Multilocation for direct withdrawal from OB.

Issue ticket number and link

#956

Checklist before requesting a review

• I have performed a self-review of my code.
• If it is a core feature, I have added thorough tests.
• I removed all Clippy and Formatting Warnings.
• I added required Copyrights.

[coderabbitai]

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[nuel77]

Id of direct deposts coming via thea should be given to engine via ingress messages? is this done?

[Gauthamastro]

Id of direct deposts coming via thea should be given to engine via ingress messages? is this done?

Yes, you can check my latest commit, I am using the H160 type as identifier for both deposit and withdrawal

[serhii-temchenko]

Should weights be re-generated for these pallets?

Also, please fix the errors caught by the CI.

[codecov]

Codecov Report

Attention: Patch coverage is 38.54749% with 110 lines in your changes are missing coverage. Please review.

Project coverage is 41.71%. Comparing base (8f669e1) to head (e6398c0).
Report is 4 commits behind head on Develop.

Files	Patch %	Lines
pallets/xcm-helper/src/lib.rs	3.44%	28 Missing ⚠️
pallets/thea-executor/src/lib.rs	57.62%	25 Missing ⚠️
pallets/ocex/src/lib.rs	47.72%	23 Missing ⚠️
primitives/thea/src/extras.rs	0.00%	11 Missing ⚠️
pallets/ocex/src/rpc.rs	0.00%	6 Missing ⚠️
pallets/thea-message-handler/src/benchmarking.rs	0.00%	3 Missing ⚠️
pallets/thea/src/benchmarking.rs	0.00%	3 Missing ⚠️
pallets/ocex/src/benchmarking.rs	0.00%	2 Missing ⚠️
pallets/thea-executor/src/benchmarking.rs	0.00%	2 Missing ⚠️
primitives/orderbook/src/traits.rs	0.00%	2 Missing ⚠️
... and 3 more

Additional details and impacted files

@@             Coverage Diff             @@
##           Develop     #959      +/-   ##
===========================================
- Coverage    41.72%   41.71%   -0.01%     
===========================================
  Files           70       72       +2     
  Lines         5773     5815      +42     
===========================================
+ Hits          2409     2426      +17     
- Misses        3364     3389      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[serhii-temchenko]

Should weights be re-generated for these pallets?

[Gauthamastro]

Should weights be re-generated for these pallets?

No we don't need that.

[serhii-temchenko]

Please check CI. It's failing again.